Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2203: Modified mobile margins to 24px #791

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

WilliamYKwon
Copy link
Contributor

@WilliamYKwon WilliamYKwon commented Jun 26, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2203

Description

Updated margin to 24px for mobile (per craig's beta design review/audit)

Deployment and testing

Post-deploy steps

  1. run npm run build in votegov theme
  2. run lando retune

QA/Testing instructions

  1. load up the local site
  2. load up the beta.vote.gov site
  3. go into mobile-screen mode through Inspect-Element for both sites.
  4. verify the local site's margins are 24px and that they are bigger than those of beta.vote.gov

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@WilliamYKwon WilliamYKwon requested review from rayestrada and clmedders and removed request for rayestrada June 26, 2024 17:24
@clmedders
Copy link
Contributor

clmedders commented Jun 26, 2024

@WilliamYKwon can you take a look at this Pr - #788

Please update yours to included testing and deploy steps. (if tester should run a lando retune or a npm run build for any style changes)

also when you are done please tag the person you wish to review in gsa jira and assign that ticket to to them

Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@WilliamYKwon WilliamYKwon requested a review from clmedders June 26, 2024 18:26
@rayestrada rayestrada dismissed clmedders’s stale review June 26, 2024 22:20

Change is approved

@rayestrada rayestrada merged commit 85eb565 into dev Jun 26, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2203-modify-mobile-margins branch July 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants