Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2270: Remove aria labels and roles #820

Merged
merged 1 commit into from
Jul 11, 2024
Merged

VOTE-2270: Remove aria labels and roles #820

merged 1 commit into from
Jul 11, 2024

Conversation

mlloydbixal
Copy link
Contributor

Jira ticket

VOTE-2270

Description

Removes redundant aria labels and role

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. Inspect page and confirm these highlighted aria labels are removed:
    image-2024-07-03-13-31-36-002

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from clmedders July 8, 2024 14:19
@clmedders clmedders merged commit d8f8e3d into dev Jul 11, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-2270/rm-aria branch July 11, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clmedders clmedders clmedders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlloydbixal @clmedders