Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2270: Remove aria labels and roles #820

Merged
merged 1 commit into from
Jul 11, 2024
Merged

VOTE-2270: Remove aria labels and roles #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/themes/custom/votegov/templates/block/block-content--email-signup.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
{# Caching the data in content object #}
{% set savedCache = content | render %}

<section{{ attributes.addClass('usa-sign-up').setAttribute('title', 'Email sign-up' | t).setAttribute('aria-label', 'Email sign-up' | t) }}>
<section{{ attributes.addClass('usa-sign-up').setAttribute('title', 'Email sign-up' | t) }}>
{# Hold these title_* placeholders for potential integration #}
{{ title_prefix }}
{{ title_suffix }}
Expand Down
4 changes: 0 additions & 4 deletions web/themes/custom/votegov/templates/component/usa-identifier.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
{# GSA logo #}
<section
class="usa-identifier__section usa-identifier__section--masthead padding-top-0"
aria-label="{{ 'Agency identifier' | t }}"
>
<div class="usa-identifier__container">
<div class="usa-identifier__logos">
Expand All @@ -14,12 +13,10 @@
class="usa-identifier__logo-img"
src="{{ theme_path }}/img/gsa-logo.svg"
alt="{{ 'GSA logo' | t }}"
role="img"
/></a>
</div>
<section
class="usa-identifier__identity"
aria-label="{{ 'Agency description' | t }}"
>
<p class="usa-identifier__identity-domain">{{ 'Vote.gov' | t }}</p>
<p class="usa-identifier__identity-disclaimer">
Expand All @@ -33,7 +30,6 @@
{# USAgov identifier #}
<section
class="usa-identifier__section usa-identifier__section--usagov"
aria-label="{{ 'U.S. government information and services' | t }}"
>
<div class="usa-identifier__container">
<p>
Expand Down
2 changes: 1 addition & 1 deletion web/themes/custom/votegov/templates/component/usagov-partner.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{# USA.gov Links #}
{% set usagov_links_block = drupal_entity('block_content', '18') %}
{% if usagov_links_block['#block_content'].langcode.value == language %}
<nav class="vote-usagov-partner__links" aria-label={{ "External election resources" | t }}>
<nav class="vote-usagov-partner__links" aria-label="{{ 'External election resources' | t }}">
{# USA.gov election info links #}
{{ usagov_links_block }}
</nav>
Expand Down