Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkout.bash and circle ci config for develop builds #44

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

msmcconnell
Copy link

PR Details

Description

This PR adds the carma-utils package to the checkout.bash as it is needed for a runtime dependency. This will resolve the primary issue in usdot-fhwa-stol/carma-platform#743, but it can be fully tested from a clean config until usdot-fhwa-stol/carma-platform#787 is also resolved. Never the less this has been tested using properly named docker images and shown to be working on the silver truck so it is safe to merge.

Related Issue

usdot-fhwa-stol/carma-platform#743,

Motivation and Context

Working develop builds

How Has This Been Tested?

Silver truck

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtbaird jtbaird merged commit 40a24c2 into develop Jul 30, 2020
@jtbaird jtbaird deleted the fix/driver_shutdown branch July 30, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants