Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party repo docker image names no longer match dockerhub #787

Closed
1 of 3 tasks
msmcconnell opened this issue Jul 30, 2020 · 1 comment
Closed
1 of 3 tasks

3rd party repo docker image names no longer match dockerhub #787

msmcconnell opened this issue Jul 30, 2020 · 1 comment
Labels
anomaly Something isn't working Severity 3 Problem in non-critical functionality

Comments

@msmcconnell
Copy link
Contributor

Types of Issue

  • Anomaly report (something appears to not work correctly)
  • Enhancement request (describe the enhancement being requested)
  • Other (please ensure the description clarifies why the issue doesn’t fall into either of the above categories)

Descriptive summary

When the CARMA repos underwent renaming the names of the forked 3rd party repos were reverted to their original names. I addition, the docker build scripts were modified such that the image name would use the repo name directly. Unfortunately, this cause a break between current images built on develop and images on dockerhub. This occurs for both the avt_vimba_camera repo and novatel_gps_driver repository. This means two switch between old and new image versions the user must change both the image name and version number. Additionally, since the new images are not associated with a dockerhub repository they must be built manually.

Probably best to revert the build script changes to ensure binaries are named as expected.

Expected behavior

Newest version of docker images can be used simply by controlling the version number and organization.

Software version this applies to

develop after 3.3.0

Actual behavior

Newest 3rd party forked repo images cannot be pushed to docker hub

Steps to reproduce the behavior

./build-image.sh -d on avt or novatel repo and observe image tag name.

Related work

Link to related tickets or prior related work here.

@msmcconnell
Copy link
Contributor Author

Resolved by above PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly Something isn't working Severity 3 Problem in non-critical functionality
Projects
None yet
Development

No branches or pull requests

2 participants