Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed to use docker hub repo for image name #45

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

jtbaird
Copy link

@jtbaird jtbaird commented Jul 30, 2020

PR Details

Description

Changes in this PR will tag images built with ./build-image.sh with the correct dockerhub repo name.

Related Issue

787

Motivation and Context

Solves an issue created by the github repo name change, where locally built docker images would use the new github repo name as the image tag, rather than the correct dockerhub repo.

How Has This Been Tested?

By running build-image.sh and verifying the image tag.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtbaird jtbaird requested a review from msmcconnell July 30, 2020 17:29
@msmcconnell msmcconnell merged commit 5148b32 into develop Jul 30, 2020
@msmcconnell msmcconnell deleted the fix/image_name branch July 30, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants