Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/image dimensions #58

Merged
merged 3 commits into from
May 5, 2021
Merged

Fix/image dimensions #58

merged 3 commits into from
May 5, 2021

Conversation

JonSmet
Copy link

@JonSmet JonSmet commented May 5, 2021

PR Details

Description

This PR reduces the image dimensions specified in the mono_camera.launch file. When using the previous image dimensions, the frequency at which images were forwarded to the carma system reached low enough rates (as measured by rostopic hz /hardware_interface/camera/image_raw) that the carma system would shutdown due to a 'camera failed' error. By reducing the image dimensions, the frequency at which images are received remains at a high enough rate that the error does not occur.

Due to these updated image dimensions, the camera and lidar on carma vehicles will need to be recalibrated. This is captured in Issue #1241: Recalibrate camera and lidar due to updated image dimensions in avt_vimba_driver's mono_camera.launch file

Related Issue

Motivation and Context

By reducing the image dimensions, the frequency at which images are received by the carma system remains at a high enough rate that a 'camera failed' issue does not occur.

How Has This Been Tested?

This has been tested on the Blue Lexus.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@msmcconnell msmcconnell merged commit 91f884a into release/zephyr May 5, 2021
@msmcconnell msmcconnell deleted the fix/image-dimensions branch May 5, 2021 20:04
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants