Add cyclone_config xml to allow ROS2 node remotely communicate with carma-platform ROS2 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
…er so that it has the config file
msmcconnell
suggested changes
Jan 3, 2023
| @@ -33,3 +33,6 @@ export CARMA_LOCZ_NS="/localization" | |||
|
|
|||
| # Namespace of nodes in the web ui stack | |||
| export CARMA_UI_NS="/ui" | |||
|
|
|||
| # configuration of CycloneDDS | |||
| export CYCLONEDDS_URI=/opt/carma/maps/cyclone_config.xml | |||
There was a problem hiding this comment.
This is putting the xml file in /opt/carma/maps. I can see why the prototype might have done that, but it doesn't make a ton of sense long term. Instead put it directly in the config so that it wouldn't need a volume.
Better to add a copy of the xml file for all the vehicles to the config and have that pointed to by the environment variable.
There was a problem hiding this comment.
additionally the change set should be applied to all vehicles
…assenger vehicles' carma configs. Not yet tested on each vehicle.
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Add cyclone_config xml to allow ROS2 node remotely communicate with carma-platform ROS2
Related Issue
usdot-fhwa-stol/cda-telematics#29
Motivation and Context
Data collection
How Has This Been Tested?
Integration testing
Types of changes
Checklist:
CARMA Contributing Guide