Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SetActiveRoute.srv to include a 'choice' field and a destination points array field #110

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

JonSmet
Copy link
Contributor

@JonSmet JonSmet commented Jun 24, 2021

PR Details

Description

This PR adds a 'choice' enumeration field to the SetActiveRoute service request, which indicates whether a RouteID (the name of a route file) or an array of destination points (specifically, an array of cav_msgs/Position3D points) is being provided. Additionally, a field for an array of cav_msgs/Position3D points is included in order to store the destination points, where the last point is the final destination point. This update is being added in order to enable the Port Drayage Plugin package in carma-platform to set a new active route based on a received destination point from CARMA Streets.

Related PRs:

carma-platform: PR #1321
carma-web-ui: PR #92

Related Issue

Motivation and Context

How Has This Been Tested?

Unit Tested in carma-platform and integration tested (using both port drayage plugin package functionality and typical carma-web-ui route-setting functionality) on the Silver Lexus and Blue Lexus.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@kjrush kjrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but holding merge to sync with usdotfhwastol/carma-platform#1321

@JonSmet JonSmet merged commit 804f8f3 into develop Aug 4, 2021
@JonSmet JonSmet deleted the feature/freight-route branch August 4, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants