Assign choice field to SetActiveRoute service request #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Jun 24, 2021
dan-du-car
approved these changes
Jul 30, 2021
JonSmet
added a commit
that referenced
this pull request
Aug 2, 2021
9 tasks
dan-du-car
added a commit
that referenced
this pull request
Aug 3, 2021
Revert SetActiveRoute update from PR #92
9 tasks
dan-du-car
added a commit
that referenced
this pull request
Aug 4, 2021
…route Assign 'choice' field to SetActiveRoute service request (re-commits change from PR #92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
CARMA Platform PR #1321 and carma-msgs PR # resulted in an updated description for cav_srvs/SetActiveRoute. Specifically, a 'choice' field was added to the request to indicate whether a SetActiveRoute request includes a RouteID (the name of a route file) or an array of destination points. Since carma-web-ui only deals with routes provided with a RouteID, the choice field is set to '0' (which indicates a RouteID is being provided).
Related PRs:
Related Issue
Motivation and Context
How Has This Been Tested?
Integration Tested on Silver Lexus and Blue Lexus.
Types of changes
Checklist:
CARMA Contributing Guide