-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Restrictions #198
Refactor Restrictions #198
Conversation
…create-feed/examples/restriction-notices/restriction-notice.geojson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed, made changes to the @DeraldDudley's v4.0-release-restrictions branch, re-reviewed, and now approve the changes.
I think we need another reviewer, as I originated several of the changes here and have a tendency to miss typos.
The specification changes made by this PR are as follows:
And in addition:
Note that the object diagram was not updated which is the team's approach as we can't merge the diagram files so those changes need to happen after the PR is merged to the release branch. @DeraldDudley added new diagram files specific to these changes, but I removed those because we don't want those files merged in. @DeraldDudley if you have time, you can put the generated object diagram image in a comment in this thread, since you've already taken the time to make them. However, they will have to change based on the difference in the proposed changes from what you had originally. |
Thanks for the review @j-d-b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Minor updates needed for /spec-content/objects/Restriction.md
and references to the old names need to be updated in /create-feed/README.md
(lines 31 and 87).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - great job @j-d-b @DeraldDudley !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @DeraldDudley and @j-d-b.
My only comment is that we should update the restrictions
description in the Lane object table to match either the schema that was modified to "A list of zero or more restrictions specific to the lane" or similar to the road event level restrictions description of "A list of zero or more road restrictions that apply to the roadway segment described by this road event."
Updated RoadEvent-level restriction on 121388-WB example in comprehensive linestring file
Thanks for all the help. Sorry to be absent the past few weeks. My workload has been challenging to manage. |
with Scenario 3 and multipoint examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple small updates to the examples for consistency, otherwise everything looks good!
@sknick-iastate I made the change. |
This PR resolves issue #155.
Changes reflect...
Add RoadEvent-RestrictionNotice FeatureUploaded Object Model and image to reflect changes (Can copy objects from my file to master file.)Uploaded RoadEvent-RestrictionNotice Object Model (Can copy objects from my file to master file.)Added and example