Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/assert option bg #2867

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

Pragadesh-45
Copy link
Contributor

Fixes: #2548

This PR fixes a UI bug that occurred when the "system" theme was used and the system's theme was set to dark mode. The bug did not occur when the "dark" theme was manually selected.

I resolved this by wrapping the style of the AssertionOperator component's option tag's background color.

Contribution Checklist:

  • The pull request addresses only one issue or adds one feature.
  • The pull request does not introduce any breaking changes.
  • I have added screenshots or gifs to help explain the change, if applicable.

Before:

After:

@helloanoop helloanoop merged commit 3ad4eda into usebruno:main Aug 21, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks @Pragadesh-45 !

@Pragadesh-45 Pragadesh-45 deleted the style/assert-option-bg branch August 21, 2024 05:27
Its-treason pushed a commit to Its-treason/bruno that referenced this pull request Aug 24, 2024
* remove old theme configs

* style bg manage from Assertion Comp for AssertionOperator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants