Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use system dark theme correctly with assertion operator dropdown #2869

Conversation

iamsushantk
Copy link
Contributor

Description

Following are the changes in short:

  • Adding name key to the theme so to reuse this across the codebase thereby reducing tech debt.
  • Fixed the issue where the assertion operator dropdown theme does not apply the system dark theme correctly. Also using correct theme variable for the dropdown.

Refer the screenshot before and after below.

Before (Dark System Theme)

image

After (Dark System Theme)

image

After (Light System Theme)

image

After (Light Theme)

image

After (Dark Theme)

image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop
Copy link
Contributor

Hey @iamsushantk !
Thanks for taking time to work on this. This issue has already been fixed in #2867

Closing this PR.

@helloanoop helloanoop closed this Aug 21, 2024
@iamsushantk iamsushantk deleted the fix/use-system-dark-theme-correctly-with-assertion-operator-dropdown branch September 6, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants