Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa localisation #1045

Merged
merged 4 commits into from
Oct 16, 2019
Merged

fa localisation #1045

merged 4 commits into from
Oct 16, 2019

Conversation

arminkhoshbin
Copy link
Contributor

Added missing Persian translations as mentioned in #1027

@codecov
Copy link

codecov bot commented Oct 13, 2019

Codecov Report

Merging #1045 into hotfix will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             hotfix    #1045   +/-   ##
=========================================
  Coverage     66.66%   66.66%           
  Complexity     1931     1931           
=========================================
  Files           162      162           
  Lines          6737     6737           
=========================================
  Hits           4491     4491           
  Misses         2246     2246

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d7690...c38804d. Read the comment docs.

@amosfolz
Copy link
Contributor

Hello @arminkhoshbin
There are still a few lines that need to be translated in this file.

There are some in the core that need checked as well.

@lcharette lcharette added the internationalization Related to the localization feature label Oct 14, 2019
@lcharette lcharette added this to the 4.3.x milestone Oct 14, 2019
@arminkhoshbin
Copy link
Contributor Author

@amosfolz no worries mate, I must have missed those. Updated the PR to include those missing translations as well now.

Let me know if there were any other ones that I might have missed.

@amosfolz
Copy link
Contributor

Looks good! Thanks.

@lcharette lcharette merged commit 60a1d9c into userfrosting:hotfix Oct 16, 2019
@lcharette lcharette removed this from the 4.5.x milestone Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internationalization Related to the localization feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants