Skip to content
This repository has been archived by the owner on Apr 28, 2024. It is now read-only.

Test Coverage Improvements #6

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Conversation

Silic0nS0ldier
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #6 into develop will increase coverage by 9.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop     #6      +/-   ##
===========================================
+ Coverage       90.9%   100%   +9.09%     
+ Complexity        92     91       -1     
===========================================
  Files              8      8              
  Lines            363    347      -16     
===========================================
+ Hits             330    347      +17     
+ Misses            33      0      -33
Impacted Files Coverage Δ Complexity Δ
...c/AssetBundles/GulpBundleAssetsCompiledBundles.php 100% <ø> (+7.14%) 6 <0> (ø) ⬇️
src/Util/MimeType.php 100% <100%> (+0.64%) 5 <0> (-1) ⬇️
src/AssetBundles/GulpBundleAssetsBundles.php 100% <100%> (+46.66%) 13 <0> (ø) ⬇️
src/AssetBundles/GulpBundleAssetsRawBundles.php 100% <100%> (+12%) 13 <0> (+1) ⬆️
src/Assets.php 100% <100%> (+15.06%) 31 <0> (+1) ⬆️
src/AssetsTemplatePlugin.php 100% <100%> (+6.81%) 14 <3> (-2) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a031f45...513617d. Read the comment docs.

- Stabalised absolute path returned by `Assets::urlPathToAbsolutePath` and hardened against silent failure.
- Slightly simplified MIME resolution logic.
- Marked usage of `Assets::readSchema` without a respository as the return value.
- Removed various bit of dead code.
- Fixed silent failure in `gulp-bundle-assets` loading support.
@Silic0nS0ldier Silic0nS0ldier marked this pull request as ready for review April 6, 2019 10:44
@Silic0nS0ldier Silic0nS0ldier requested a review from lcharette April 6, 2019 11:09
@lcharette
Copy link
Member

The diff coverage is 100% 🍾

@Silic0nS0ldier Silic0nS0ldier merged commit 6425b7d into develop Apr 7, 2019
@Silic0nS0ldier Silic0nS0ldier deleted the feature-testCoverage branch April 7, 2019 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants