Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Ushahidi\App namespace for app code not tied to Kohana #674

Closed
rjmackay opened this issue Sep 1, 2015 · 2 comments
Closed

Create Ushahidi\App namespace for app code not tied to Kohana #674

rjmackay opened this issue Sep 1, 2015 · 2 comments
Assignees

Comments

@rjmackay
Copy link
Contributor

rjmackay commented Sep 1, 2015

  • Currently we use application/ for implementation specific code. However this also ties things to Kohana
  • For code which isn't tied to kohana but is implementation specific it'd be good to move into src/App so we can use PSR4 etc
@rjmackay
Copy link
Contributor Author

This might be a good idea as prep for the move away from Kohana #1372

@rjmackay
Copy link
Contributor Author

I'm trying to sort out a naming scheme for platform that avoids having an Ushahidi\App layer since that'll get confusing with Laravels typical App namespacing. I'm consider something like

Ushahidi\Core : Domain layer has entities, repo interfaces, usecase
Ushahidi\Infrastructure or just Ushahidi\Infra : concrete repos, validators, tooling (what I had started moving into Ushahidi\App)
Ushahidi\App .. whats normally in laravels App : controllers, routes, other laravel specific wiring

I'd also like to group things by model a bit more so you would have clear Post, Survey, User etc folders. That would put the Post validator, repo, formatter etc alongside each other.. just not quite sure how to manage that with the Domain / Infra / App split.

nimishmedatwal pushed a commit to nimishmedatwal/platform that referenced this issue Mar 11, 2024
Co-authored-by: Shakira <shakira@Shakiras-MacBook-Pro.local>
Co-authored-by: AmTryingMyBest <38259840+AmTryingMyBest@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant