Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Application layer into src/App #1644

Merged
merged 2 commits into from
Mar 31, 2017
Merged

Move Application layer into src/App #1644

merged 2 commits into from
Mar 31, 2017

Conversation

rjmackay
Copy link
Contributor

@rjmackay rjmackay commented Mar 16, 2017 •
edited
Loading

This pull request makes the following changes:

  • Moving application layer out of kohana land into src/app

Test these changes by:

  • Run tests

Fixes #674

Ping @ushahidi/platform

This change is Reviewable

@rjmackay rjmackay requested review from willdoran and jasonmule March 16, 2017 02:45
@rjmackay rjmackay force-pushed the psr-ushahidi-classes branch from 1ca4d08 to 58882bb Compare March 16, 2017 08:10
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 69.806% when pulling 58882bb on psr-ushahidi-classes into 8ccfd0a on develop.

@rjmackay rjmackay mentioned this pull request Mar 30, 2017
Merged
13 tasks
@rjmackay rjmackay force-pushed the psr-ushahidi-classes branch from 58882bb to 3f81b07 Compare March 30, 2017 23:53
rjmackay added 2 commits March 31, 2017 12:59
@rjmackay
Set up Ushahidi\App namespace and move the simple classes
95150c8 
Migrating the easy, non kohana related stuff into a namespace
@rjmackay
Format for PSR2
e7575c3
@rjmackay rjmackay force-pushed the psr-ushahidi-classes branch from 3f81b07 to e7575c3 Compare March 31, 2017 00:00
@rjmackay rjmackay merged commit 4dfa142 into develop Mar 31, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 69.763% when pulling e7575c3 on psr-ushahidi-classes into ef50cc5 on develop.

@tuxpiper tuxpiper deleted the psr-ushahidi-classes branch March 24, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdoran willdoran Awaiting requested review from willdoran

@jasonmule jasonmule Awaiting requested review from jasonmule

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmackay @coveralls