Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

857 updates #1273

Conversation

Rene2mt
Copy link
Contributor

@Rene2mt Rene2mt commented May 17, 2022

Committer Notes

This PR addresses issue #857 and issue #909 for review. The local working branch was rebased off main so this PR includes other commits that were not previously merged to the feature branch (feature-metadata-extension-tutorial).

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@david-waltermire david-waltermire changed the title 857 wip 857 updates May 26, 2022
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

I'll give this an editorial pass in the feature branch before merging #1011.

@david-waltermire david-waltermire merged commit 4a94ea6 into usnistgov:feature-metadata-extension-tutorial Jun 1, 2022
david-waltermire added a commit that referenced this pull request Jul 14, 2022
* Made major updates to the metadata tutorial page
* Made updates to props and links tutorial page
* Added new links to walkthrough tutorials page

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
david-waltermire added a commit that referenced this pull request Jul 25, 2022
* Adding metadata tutorial page
* Fixing links to match new link contract
* updated rlink reference
* 857 extension mechanisms (#1031)
* Added json and yaml example snippets
* Added link to allowed values documentation
* Added hugo callouts and minor tweaks
* 857 updates (#1273)
* Completed an editorial pass through the metadata and extension tutorial. Revised the prop portion of the extension tutorial to provide a better conceptualization
* Reorganized the tutorials to follow the model layer organization.

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: stephenbanghart <banghasa@dukes.jmu.edu>
Co-authored-by: Stephen Banghart <stephen.banghart@nist.gov>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@noblis.org>
Co-authored-by: Rene2mt <76444659+Rene2mt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants