Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model refactoring based on feedback (Session 1) #614

Conversation

david-waltermire
Copy link
Contributor

Committer Notes

Work on multiple issues described by the epic #597.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@david-waltermire
Copy link
Contributor Author

I mistakenly referenced #518 when I intended to reference #581.

@@ -93,19 +99,42 @@
</remarks>
<o:profile>
<o:metadata>
<o:link rel="reference" href="#citation1">My citation</o:link>
<o:link rel="citation" href="#resource1">My citation</o:link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear at https://www.iana.org/assignments/link-relations/link-relations.xhtml (although the previous one didn't either).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use rels that are not in the link relations IANA registry. I think we need to come up with a means for the IANA relations and the OSCAL relations to co-exist.

@david-waltermire
Copy link
Contributor Author

PR #619 includes these changes. Closing this PR.

@david-waltermire david-waltermire deleted the issue597-refactoring-session-1 branch March 28, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants