Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguous file paths in the repo #566

Closed
isimluk opened this issue Dec 16, 2019 · 5 comments
Closed

Ambiguous file paths in the repo #566

isimluk opened this issue Dec 16, 2019 · 5 comments
Assignees
@wendellpiez @david-waltermire
Labels
bug Scope: Repository
Milestone
OSCAL 1.0 Milesto...

Comments

@isimluk
Copy link
Contributor

isimluk commented Dec 16, 2019

Hello guys, thank You for your work.

I found few filepaths in the repo that probably shouldn't be there at this point. Here are couple of examples:

$ git grep wap1
build/metaschema/lib/produce-datatype-validation-functions.xsl:         Calls data from file:/C:/Users/wap1/Documents/OSCAL/build/metaschema/xml/produce-xsd.xsl and
build/metaschema/lib/produce-datatype-validation-functions.xsl:                         file:/C:/Users/wap1/Documents/OSCAL/build/metaschema/xml/oscal-datatypes.xsd
build/metaschema/xml/produce-and-run-either-documentor.xsl:        <!--file:/C:/Users/wap1/Documents/usnistgov/OSCAL/docs/layouts/partials/generated/xml-schema-oscal-catalog.html-->

$ git grep davidwal
src/metaschema/examples/computer-build.json:  "$schema": "file:/home/davidwal/github/david-waltermire-nist/OSCAL/json/schema/computer-build_schema.json",

$ git grep home.wendell
src/utils/util/convert/json-compactor.xsl:    <xsl:variable name="metaschema" select="document('file:/home/wendell/Documents/OSCAL/schema/metaschema/oscal-catalog-metaschema.xml')"/>
src/utils/util/lib/make-xslt.xq:    <doc>file:/home/wendell/Documents/OSCAL/draft/working/SP800-53/SP800-53-handmade.xml</doc>
src/utils/util/lib/make-xslt.xq:    <doc>file:/home/wendell/Documents/OSCAL/draft/working/ISO-27002/iso-27002-OSCAL.xml</doc>
src/utils/util/lib/make-xslt.xq:    <doc>file:/home/wendell/Documents/OSCAL/draft/working/doc/oscal-oscal.xml</doc>
src/utils/util/lib/utility.xq:    <doc>file:/home/wendell/Documents/OSCAL/working/COBIT5/cobit5-selection-oscal.xml</doc>
src/utils/util/lib/utility.xq:    <doc>file:/home/wendell/Documents/OSCAL/working/ISO-27002/iso-27002-OSCAL-refined.xml</doc>
src/utils/util/lib/utility.xq:    <doc>file:/home/wendell/Documents/OSCAL/working/SP800-53/SP800-53-OSCAL-refined.xml</doc>
src/utils/util/lib/utility.xq:    <doc>file:/home/wendell/Documents/OSCAL/working/doc/schema/oscal-oscal.xml</doc>
@isimluk isimluk added the bug label Dec 16, 2019
@david-waltermire david-waltermire added this to the OSCAL 1.0 Milestone 3 milestone Jan 9, 2020
@david-waltermire
Copy link
Contributor

Fixing the davidwal path in PR #605.

@isimluk
Copy link
Contributor Author

isimluk commented Jan 23, 2020

👍 Thanks!

wendellpiez added a commit to wendellpiez/OSCAL that referenced this issue Jan 23, 2020
@wendellpiez
Scrubbed references to me (my local files) in files committed see usn…
7bd083a 
…istgov#566
@wendellpiez wendellpiez mentioned this issue Jan 23, 2020
Merged
4 tasks
david-waltermire pushed a commit that referenced this issue Jan 23, 2020
@wendellpiez @david-waltermire
Scrubbed references to me (my local files) in files committed see #566
4554943
@david-waltermire
Copy link
Contributor

This is closable once PR #605 is merged.

david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Jan 28, 2020
@david-waltermire
Fixed local path in file for issue usnistgov#566
969b729
david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Jan 28, 2020
@david-waltermire
Fixed local path in file for issue usnistgov#566
35e3ecb
@wendellpiez
Copy link
Contributor

Sprint 26 Update Jan 30 2020

Note last week's comment. @david-waltermire-nist has corrections in a branch to be merged.

david-waltermire added a commit to usnistgov/metaschema that referenced this issue Feb 5, 2020
@david-waltermire @wendellpiez
Additional refactoring of build scripts and supporting files (#37)
54de324 
* integrated schema generation unit tests with new build scripting
* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue #11: JSON Schema missing constraint at root
* Adding metaschema documentation. #16 usnistgov/OSCAL#596
* Added CI/CD files for website.
* Added Github issue templates.
* Addressing #12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination
* removed extra files

Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
david-waltermire added a commit to usnistgov/metaschema that referenced this issue Feb 5, 2020
@wendellpiez @david-waltermire
Enhancing XML- and JSON -conversion logic for metaschema constructs (#36
b234d5a 
)

* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue #11: JSON Schema missing constraint at root
* Adding metaschema documentation. #16 usnistgov/OSCAL#596
* Added CI/CD files for website.
Added Github issue templates.
* Addressing #12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
david-waltermire added a commit to usnistgov/metaschema that referenced this issue Feb 5, 2020
@david-waltermire @wendellpiez
Build metaschema refactor (#38)
ad1ce45 
* integrated schema generation unit tests with new build scripting
* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue #11: JSON Schema missing constraint at root
* Adding metaschema documentation. #16 usnistgov/OSCAL#596
* Added CI/CD files for website.
* Added Github issue templates.
* Addressing #12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination
* removed extra files

Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Feb 5, 2020
@david-waltermire
Fixed local path in file for issue usnistgov#566
33bb51f
david-waltermire added a commit that referenced this issue Feb 5, 2020
@david-waltermire
Fixed local path in file for issue #566
71666f9
@david-waltermire
Copy link
Contributor

This was addressed in PR #605.

david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Feb 6, 2020
@david-waltermire
Fixed local path in file for issue usnistgov#566
89408d1
nikitawootten-nist pushed a commit to nikitawootten-nist/metaschema-xslt that referenced this issue Jul 21, 2023
@david-waltermire @wendellpiez
Additional refactoring of build scripts and supporting files (usnistg…
dd329a9 
…ov#37)

* integrated schema generation unit tests with new build scripting
* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue usnistgov#11: JSON Schema missing constraint at root
* Adding metaschema documentation. usnistgov#16 usnistgov/OSCAL#596
* Added CI/CD files for website.
* Added Github issue templates.
* Addressing usnistgov#12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination
* removed extra files

Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
nikitawootten-nist pushed a commit to nikitawootten-nist/metaschema-xslt that referenced this issue Jul 21, 2023
@wendellpiez @david-waltermire
Enhancing XML- and JSON -conversion logic for metaschema constructs (u…
eb307cb 
…snistgov#36)

* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue usnistgov#11: JSON Schema missing constraint at root
* Adding metaschema documentation. usnistgov#16 usnistgov/OSCAL#596
* Added CI/CD files for website.
Added Github issue templates.
* Addressing usnistgov#12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
nikitawootten-nist pushed a commit to nikitawootten-nist/metaschema-xslt that referenced this issue Jul 21, 2023
@david-waltermire @wendellpiez
Build metaschema refactor (usnistgov#38)
73b6ffb 
* integrated schema generation unit tests with new build scripting
* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue usnistgov#11: JSON Schema missing constraint at root
* Adding metaschema documentation. usnistgov#16 usnistgov/OSCAL#596
* Added CI/CD files for website.
* Added Github issue templates.
* Addressing usnistgov#12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination
* removed extra files

Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wendellpiez wendellpiez

@david-waltermire david-waltermire

Labels
bug Scope: Repository
Projects
None yet
Milestone
OSCAL 1.0 Milestone 3
Development

No branches or pull requests
3 participants
@wendellpiez @isimluk @david-waltermire