-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSCAL Model Maps - further enhancements #36
Comments
…ss-browser testing see usnistgov/metaschema#91
Summary version: For what we need to control line items in the tree, fixing widths and flowing where we need, CSS We could get around this by going back to a JS collapse/expansion implementation. Alternatively, Chrome may be updated or there may be a CSS-based solution for Chrome. |
…ss-browser testing see usnistgov/metaschema#91
…ss-browser testing see usnistgov/metaschema#91
Now done in PR usnistgov/metaschema#127. |
…snistgov#36) * Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips. * added required top-level property to all unit-test JSON schema files * Added XSD targets for unit testing * oXygen project file for metaschema testing * Updated project file * Test coverage and planning docs * added unit test for collapse * fixed a bug in the test script causing expected schema files to not be compared. * Addressing Issue usnistgov#11: JSON Schema missing constraint at root * Adding metaschema documentation. usnistgov#16 usnistgov/OSCAL#596 * Added CI/CD files for website. Added Github issue templates. * Addressing usnistgov#12, supporting collapsibility of fields. * Fixed website build error. * Updating website contents and CI/CD configuration. * Patch to catch up metaschema implementation to latest changes in the OSCAL repo. * fixed broken links in documentation * updated repository documentation to fix broken links * added configuration support to build scripts * Implemented content converter generation in build scripts * Removed references to local files for usnistgov/OSCAL#566 * integrated schema generation unit tests with new build scripting * Now accounting for json-value-key/json-key combination Co-authored-by: David Waltermire <david.waltermire@nist.gov>
User Story:
Further work is possible improving the XML and JSON model maps as produced for documentation for example in OSCAL documentation.
In particular, we agreed in a Lunch w/ Devs (Dec 3 2020) when looking at mockups, that we would like to produce the map entries with item cardinalities listed to the left of each item, in a tabular arrangement (within the expanding tree), something like as shown in this screenshot:
However, it proves difficult to implement this layout to work consistently across browsers as of this date.
Goals:
Implement a clean, portable map design showing a cleaner "gridded" arrangement with nesting than the current model maps. Show item cardinality on the left as in the screenshot above.
Whitespace and indenting integrity must be maintained as the view is arbitrarily expanded and collapsed. In particular, line wrap must be clean when lines grow too long to fit.
Dependencies:
If browser support for
list-style-position
onsummary
is supported across browsers, then summaries can be listed with correct vertical alignment. (See https://www.caniuse.com/?search=summary%20list-item) This is tricky especially since HTMLdisplay/summary
may be wanted on some items, while other neighboring items are not made to expand.We also need to make sure that the expansion icon shows even if the summary contains flex boxes (as of now in FF, it does not, while in Chrome, it does), potentially with CSS to that effect.
Tips:
This commit represents a best effort WIP before factoring this work back out: wendellpiez/metaschema@57acadd
summary { display: flex }
may helpAcceptance Criteria
{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}
The text was updated successfully, but these errors were encountered: