Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field collapse is not properly handled in schema generation #11

Open
david-waltermire opened this issue Dec 10, 2019 · 3 comments
Open

Field collapse is not properly handled in schema generation #11

david-waltermire opened this issue Dec 10, 2019 · 3 comments
Assignees
@wendellpiez
Labels
blocked bug Something isn't working

Comments

@david-waltermire
Copy link
Collaborator

The toolchains/oscal-m2 implementation does not properly generate a JSON schema for a field-definition with collapsible=true.

Unit tests that illustrate this bug are included in PR usnistgov/metaschema#10, which have been integrated into master.
@david-waltermire david-waltermire added the bug Something isn't working label Dec 10, 2019
@wendellpiez wendellpiez changed the title Field collapse is not property handled in schema generation Field collapse is not properly handled in schema generation Dec 12, 2019
@wendellpiez wendellpiez mentioned this issue Dec 12, 2019
Merged
@wendellpiez
Copy link
Collaborator

See the PR at usnistgov/metaschema#13.

david-waltermire referenced this issue in usnistgov/metaschema Jan 10, 2020
@wendellpiez @david-waltermire
Addressing #12, supporting collapsibility of fields.
f7325ec
wendellpiez referenced this issue in wendellpiez/metaschema Feb 5, 2020
@wendellpiez
Addressing #12, supporting collapsibility of fields.
a219914
david-waltermire referenced this issue in usnistgov/metaschema Feb 5, 2020
@david-waltermire @wendellpiez
Additional refactoring of build scripts and supporting files (#37)
54de324 
* integrated schema generation unit tests with new build scripting
* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue #11: JSON Schema missing constraint at root
* Adding metaschema documentation. #16 usnistgov/OSCAL#596
* Added CI/CD files for website.
* Added Github issue templates.
* Addressing #12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination
* removed extra files

Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
david-waltermire referenced this issue in usnistgov/metaschema Feb 5, 2020
@wendellpiez @david-waltermire
Enhancing XML- and JSON -conversion logic for metaschema constructs (#36
b234d5a 
)

* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue #11: JSON Schema missing constraint at root
* Adding metaschema documentation. #16 usnistgov/OSCAL#596
* Added CI/CD files for website.
Added Github issue templates.
* Addressing #12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
david-waltermire referenced this issue in usnistgov/metaschema Feb 5, 2020
@david-waltermire @wendellpiez
Build metaschema refactor (#38)
ad1ce45 
* integrated schema generation unit tests with new build scripting
* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue #11: JSON Schema missing constraint at root
* Adding metaschema documentation. #16 usnistgov/OSCAL#596
* Added CI/CD files for website.
* Added Github issue templates.
* Addressing #12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination
* removed extra files

Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
@wendellpiez wendellpiez mentioned this issue Mar 12, 2020
Closed
25 tasks
@wendellpiez
Copy link
Collaborator

wendellpiez commented Feb 14, 2023 •
edited
Loading

This feature is currently not supported in the XSLT implementation, and it is not used in OSCAL.

To support it across multiple implementations really demands unit tests.

Let's make a determination on how to approach this feature (and possibly others) in view of the need to externalize both specifications and unit tests / demonstrations. We can then either close or move this Issue.

@david-waltermire david-waltermire transferred this issue from usnistgov/metaschema Jun 30, 2023
@wendellpiez
Copy link
Collaborator

See usnistgov/metaschema#354 (and close when it closes)

nikitawootten-nist pushed a commit to nikitawootten-nist/metaschema-xslt that referenced this issue Jul 21, 2023
@wendellpiez @david-waltermire
Addressing Issue usnistgov#11: JSON Schema missing constraint at root
c2c7325
nikitawootten-nist pushed a commit to nikitawootten-nist/metaschema-xslt that referenced this issue Jul 21, 2023
@david-waltermire @wendellpiez
Additional refactoring of build scripts and supporting files (usnistg…
dd329a9 
…ov#37)

* integrated schema generation unit tests with new build scripting
* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue usnistgov#11: JSON Schema missing constraint at root
* Adding metaschema documentation. usnistgov#16 usnistgov/OSCAL#596
* Added CI/CD files for website.
* Added Github issue templates.
* Addressing usnistgov#12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination
* removed extra files

Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
nikitawootten-nist pushed a commit to nikitawootten-nist/metaschema-xslt that referenced this issue Jul 21, 2023
@wendellpiez @david-waltermire
Enhancing XML- and JSON -conversion logic for metaschema constructs (u…
eb307cb 
…snistgov#36)

* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue usnistgov#11: JSON Schema missing constraint at root
* Adding metaschema documentation. usnistgov#16 usnistgov/OSCAL#596
* Added CI/CD files for website.
Added Github issue templates.
* Addressing usnistgov#12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
nikitawootten-nist pushed a commit to nikitawootten-nist/metaschema-xslt that referenced this issue Jul 21, 2023
@david-waltermire @wendellpiez
Build metaschema refactor (usnistgov#38)
73b6ffb 
* integrated schema generation unit tests with new build scripting
* Work in progress on metaschema-related updates towards OSCAL SSP conversion roundtrips.
* added required top-level property to all unit-test JSON schema files
* Added XSD targets for unit testing
* oXygen project file for metaschema testing
* Updated project file
* Test coverage and planning docs
* added unit test for collapse
* fixed a bug in the test script causing expected schema files to not be compared.
* Addressing Issue usnistgov#11: JSON Schema missing constraint at root
* Adding metaschema documentation. usnistgov#16 usnistgov/OSCAL#596
* Added CI/CD files for website.
* Added Github issue templates.
* Addressing usnistgov#12, supporting collapsibility of fields.
* Fixed website build error.
* Updating website contents and CI/CD configuration.
* Patch to catch up metaschema implementation to latest changes in the OSCAL repo.
* fixed broken links in documentation
* updated repository documentation to fix broken links
* added configuration support to build scripts
* Implemented content converter generation in build scripts
* Removed references to local files for usnistgov/OSCAL#566
* integrated schema generation unit tests with new build scripting
* Now accounting for json-value-key/json-key combination
* removed extra files

Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
nikitawootten-nist pushed a commit to nikitawootten-nist/metaschema-xslt that referenced this issue Jul 21, 2023
@wendellpiez @david-waltermire
Finishing up usnistgov#11: constraining the root to be one (and only …
65f55ca 
…one) of the designated assemblies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wendellpiez wendellpiez

Labels
blocked bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wendellpiez @david-waltermire