Skip to content

Conversation

@kevinburke
Copy link
Contributor

Previously, attempting to compile on Macs would bring in the SELinux dependencies (runcon) which led to compilation errors on Macs.

Fixes #7695.

@kevinburke kevinburke force-pushed the no-selinux-mac branch 2 times, most recently from ec94710 to ec95e76 Compare May 20, 2025 17:29
@sylvestre
Copy link
Contributor

could you please add a job in the CI to make sure we don't regress ?

@kevinburke
Copy link
Contributor Author

There's a Mac ARM build in there already, and it's passing on main/master. So I would need to find the difference between the Mac ARM build in CI, and my Mac. I'm not sure the best way to do that.

@kevinburke
Copy link
Contributor Author

Ah - the CICD sets the feat_os_macos flag, which I wasn't. So I can reproduce the behavior on main with the following target:

make install PREFIX=/Users/kburke/local/coreutils BUILD_SPEC_FEATURES=feat_os_macos

And we can make CICD reproduce my failing build by removing the feat_os_macos flag.

I don't know, it feels a bit duplicative to have to set that flag explicitly.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@kpcyrd
Copy link

kpcyrd commented May 26, 2025

@kevinburke can you check if the ifeq ($(SELINUX_ENABLED),1) based solution described in #7996 works for you?

@sylvestre
Copy link
Contributor

Now that you found the culprit, could you please extend the ci to the test this combination? Thanks

Previously, attempting to compile on Macs would bring in the SELinux
dependencies (runcon) which led to compilation errors on Macs.

Fixes uutils#7695.
@kevinburke
Copy link
Contributor Author

@sylvestre here is that commit, it is the only commit that does not have a "features" tag - kevinburke@24ff36ee8

I'm still a bit confused - isn't there something that can set default "features" based on the compilation architecture, and then you can override it if need be.

@kevinburke
Copy link
Contributor Author

@kpcyrd I can compile on Mac with no problems if I remove this patch and apply your patch.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit 858db60 into uutils:main Jun 6, 2025
115 of 116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation failure using 'make install' on Mac

3 participants