Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Nov 15, 2025

Preliminary for #9037 . Since we have tests for *con stubs, #7964 seems no longer needed.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 15, 2025

CodSpeed Performance Report

Merging #9286 will not alter performance

Comparing oech3:merge-mac-art (19da2c7) with main (62121a9)1

Summary

✅ 123 untouched
⏩ 5 skipped2

Footnotes

  1. No successful run was found on main (8fc9d28) during the generation of this report, so 62121a9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

if [ -z "${{ matrix.job.features }}" ]; then ARTIFACTS_SUFFIX='-nofeatures' ; fi
outputs CARGO_CMD
outputs CARGO_CMD_OPTIONS
outputs ARTIFACTS_SUFFIX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
outputs ARTIFACTS_SUFFIX
# package name (must be set after ARTIFACTS_SUFFIX is determined)
PKG_suffix=".tar.gz" ; case '${{ matrix.job.target }}' in *-pc-windows-*) PKG_suffix=".zip" ;; esac;
PKG_BASENAME=${PROJECT_NAME}-${REF_TAG:-$REF_SHAS}-${{ matrix.job.target }}${ARTIFACTS_SUFFIX}
PKG_NAME=${PKG_BASENAME}${PKG_suffix}
outputs PKG_suffix PKG_BASENAME PKG_NAME

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before
PKG_BASENAME=${PROJECT_NAME}-${REF_TAG:-$REF_SHAS}-${{ matrix.job.target }}
after
PKG_BASENAME=${PROJECT_NAME}-${REF_TAG:-$REF_SHAS}-${{ matrix.job.target }}${ARTIFACTS_SUFFIX}

Now the release assets will have unique names:

  • coreutils-0.3.0-x86_64-unknown-linux-gnu.tar.gz (use-cross version)
  • coreutils-0.3.0-x86_64-unknown-linux-gnu-nocross.tar.gz (no-cross version)
  • coreutils-0.3.0-aarch64-apple-darwin-nocross.tar.gz (with features)
  • coreutils-0.3.0-aarch64-apple-darwin-nofeatures.tar.gz (without features)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can no we just drop one for simplity?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

Copy link
Contributor Author

@oech3 oech3 Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeing download URL could break downstream's binary packages. I want to avoid it if possible.
Is cross version still useful?

@oech3
Copy link
Contributor Author

oech3 commented Nov 15, 2025

At least, the test I tried to remove by this PR is covered by

- name: Build SELinux utilities as stubs
run: cargo build -p uu_chcon -p uu_runcon
- name: Verify stub binaries exist
shell: bash
run: |
test -f target/debug/chcon || test -f target/debug/chcon.exe
test -f target/debug/runcon || test -f target/debug/runcon.exe

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@naoNao89
Copy link
Contributor

Sorry, I can’t help you much right now. This needs to be debugged on the CI, and since you’ve already got a PR open and it’s running, I don’t want to pile on and stress our infrastructure :v

@oech3
Copy link
Contributor Author

oech3 commented Nov 15, 2025

OK. thankyou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants