Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy-20241025 #163

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Deploy-20241025 #163

merged 7 commits into from
Nov 15, 2024

Conversation

ItsUnagii
Copy link
Contributor

Got 256GB SD cards. C at E18 bridge on deploy-20241018 had to be recovered early, and O at Carp Pond appeared to be tampered with. Due to risk of further tampering, the locations of the deployment for those two sites were altered - the exact coordinates of which are reflected in the field records. There is also some slight orange mud substance currently in audiomoth O.

@aditya-uw
Copy link
Contributor

@ItsUnagii I think there's an error in one of the entries that prevents GitHub from displaying the .csv as a .csv
Could you try to debug that? And I'll add pictures to this PR and the PR before.

And could you briefly explain (maybe in the notes of the field records and in this PR) why the lat/lons are not filled in? (I know why but this is good practice so when someone outside our group looks at our records they have multiple references explaining why there are changes in how the field records are entered)

@ItsUnagii
Copy link
Contributor Author

@aditya-uw Fixed. I forgot I can't leave comments in notes because of the csv.

Starting from this deployment onwards, lat/lon values for current sites will not be filled in. We found that marking coordinates for every deployment was redundant considering the little amount of variation between coordinates by site. Instead, we will only be marking coordinates if the deployment site location changes (e.g. due to finding a better hiding spot).

@aditya-uw
Copy link
Contributor

@ItsUnagii could you also add like a "lat/lon entries will no longer be entered if location is not changed" to the notes column of all deploy-20241018 and deploy-20241025 rows? Just in case someone only downloads the .csv and they don't look at our PRs. We can include this note for deploy-20241104 as well just to be safe but I think it's fine if we drop it after.

@ItsUnagii
Copy link
Contributor Author

@aditya-uw Finished. Let me know if there's anything else that's needed.

@aditya-uw
Copy link
Contributor

@ItsUnagii Oh I just noticed, you have lat/lon in Telephone Field but I think you meant to have it in Carp Pond? Revisit your excel and verify that it's just the lat/lon you entered wrong and nothing else?

@ItsUnagii
Copy link
Contributor Author

@aditya-uw It is done. Should be fixed by now - it's kind of unfortunate how many errors I had with this PR. Hopefully we get nothing else.

@aditya-uw
Copy link
Contributor

aditya-uw commented Nov 15, 2024

@ItsUnagii Oh I think you forgot to remove the longitude from Telephone Field just now haha, it's alright! This is why it's also good to check over your work multiple times. Wu-Jung also mentioned something about how copy-pasting can make these kinds of things happen. You can try to make certain columns require manual entry while having the more constant entries be auto-filled.

After you fix that could you also check one of the previous closed PRs (I think deploy-20241018) and address Wu-Jung's comment? She talked about adding something about the lat/lon entries in one of the relevant .md files. You can do that with this PR or with your other PR. Ping me after you finish with these!

@ItsUnagii
Copy link
Contributor Author

@aditya-uw Anything other than the comment I should add to the md files? The main one that displays on the repository when you open it is outdated (says 2022 is ongoing) and I think we should list something about changing to 9 batteries and 256gb sd cards.

@aditya-uw
Copy link
Contributor

aditya-uw commented Nov 15, 2024

@ItsUnagii I think Wu-Jung meant the 2024.md file that is in field records. That's supposed to describe our 2024 recording season so how about there you put the sd card stuff too? And sure you can update the main README.md as well but I think let's maintain consistency and just put down where we are at right now.

Makes sense?

Could one of you put this in the 2024 md file so that it is easy to spot
later? Thanks!

@ItsUnagii
Copy link
Contributor Author

Yeah, I meant adding 256gb sd card information, etc. to the 2024.md file. For this PR I'll just add what Wu-Jung said to do, and update the other things at a later time.

@aditya-uw
Copy link
Contributor

Ah okay yeah I see what you meant now, thanks!

@aditya-uw
Copy link
Contributor

aditya-uw commented Nov 15, 2024

@ItsUnagii Wait but actually yeah go ahead and write about the 9 batteries and 256GB sd cards as well, since we're editing the ubna_2024.md file.

@ItsUnagii
Copy link
Contributor Author

@aditya-uw how does that look?

@aditya-uw
Copy link
Contributor

@ItsUnagii Awesome! nicely descriptive! I can merge this and I can also leave a comment on your other PR about updating the README.md just for records (you don't have to address it now or anything)

@aditya-uw aditya-uw merged commit 727649a into main Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants