IRONN-270 hotfix. #4423
Merged
IRONN-270 hotfix. #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v24.10.10
Address a stream of 400 errors (CSRF token is missing) related to saving patientlist table preferences. Cause: I think the error stemmed from when an ajax request was first made to retrieve patient data, which is precedes by a call to save table preferences, the document DOM was not ready (which includes the value of CSRF token in an hidden element) - hence the missing CSRF token error. Fix: To add check for DOM readiness before the request to save table preferences is made. --------- Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
accidentally merged [this](#4413) into Master, reverted that. Will merge this into the `develop` branch. Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
…ates overwrites was expiring prior to completion.
|
Hello @pbugni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
mcjustin
approved these changes
Nov 8, 2024
ivan-c
approved these changes
Nov 13, 2024
ivan-c
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also https://movember.atlassian.net/browse/IRONN-270
The
TimeoutLockused to prevent concurrent EMPRO trigger states overwrites was expiring prior to completion.Elaborate chain of events needed to reproduce the problem, but the existing 60 second timeout for any single user's updates to their trigger_states->triggers data was inadequate when other jobs (such as
update_patients_task) came in before completion of trigger processing.The end result was an area of code intended to be locked in a critical section, would obtain a fresh lock even if one was in use, when it had been longer than the expiration time.
This PR gives more than adequate space (2 hours rather than 60 seconds).