Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): add skywalking-eyes license header check #2867

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

homksei
Copy link
Contributor

@homksei homksei commented Aug 2, 2024

Description

Added skywalking-eyes license header check:

  • .github/workflows/skywalking-eyes.yml workflow (actually, the check itself)
  • .github/.licenserc.yaml config for checker

Additionally:

Copyrights in some files were updated:

  • Added license header to the following .md files:

    • .github/ISSUE_TEMPLATE/RFC.md
    • .github/ISSUE_TEMPLATE/bug_report.md
    • .github/ISSUE_TEMPLATE/documentation.md
    • .github/ISSUE_TEMPLATE/feature_request.md
    • .github/pull_request_template.md
    • CODE_OF_CONDUCT.md
  • Removed second year in copyright notice for the following files:

    • cpp/daal/src/externals/service_math_ref.h
    • cpp/oneapi/dal/algo/decision_forest/backend/gpu/train_kernel_hist_impl.hpp
    • cpp/oneapi/dal/algo/decision_forest/backend/gpu/train_kernel_hist_impl_dpc.cpp
    • cpp/oneapi/dal/algo/decision_forest/backend/gpu/train_service_kernels.hpp
    • cpp/oneapi/dal/algo/decision_forest/backend/gpu/train_service_kernels_dpc.cpp
  • Fixed framing for the following .rst files (in docs/source):

    • docs/source/404.rst
    • docs/source/api/algorithms/clustering/dbscan.rst
    • docs/source/api/algorithms/clustering/index.rst
    • docs/source/api/algorithms/clustering/kmeans-init.rst
    • docs/source/api/algorithms/clustering/kmeans.rst
    • docs/source/api/algorithms/covariance/covariance.rst
    • docs/source/api/algorithms/covariance/index.rst
      ...

@homksei homksei marked this pull request as ready for review August 2, 2024 14:37
@homksei homksei force-pushed the chore-add-reuse-tool-check branch from f16c204 to 7c41cfb Compare August 2, 2024 15:40
header:
license:
spdx-id: Apache-2.0
copyright-owner: contributors to the oneDAL project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it also check that older Intel copyright owner that still exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this field so it won't be confusing, as it's not used for check.

@homksei homksei force-pushed the chore-add-reuse-tool-check branch from 7c41cfb to 6ceea9b Compare August 3, 2024 19:53
@homksei homksei requested a review from napetrov August 3, 2024 19:58
Copy link
Contributor

@napetrov napetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that overall check works and it would catch copyright that is not compliant

# Clang-format configs
- '.clang-format'
# All .md files
- '**/*.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have md files with copyrights - should we keep them for check? How many failures?

Might be as a next pr discussion on exclusion - fine to merge this one as is

@homksei homksei force-pushed the chore-add-reuse-tool-check branch from f785071 to e102d97 Compare August 4, 2024 20:41
@homksei homksei marked this pull request as draft September 9, 2024 06:53
@homksei homksei force-pushed the chore-add-reuse-tool-check branch from e102d97 to b0b12d4 Compare October 25, 2024 12:35
@homksei homksei force-pushed the chore-add-reuse-tool-check branch 5 times, most recently from 34e80b0 to 34afa43 Compare October 31, 2024 07:18
@homksei homksei force-pushed the chore-add-reuse-tool-check branch from eb9e77a to 8b66580 Compare November 13, 2024 08:30
@homksei
Copy link
Contributor Author

homksei commented Dec 2, 2024

/azp run

@homksei homksei force-pushed the chore-add-reuse-tool-check branch 2 times, most recently from 304c789 to 703bee6 Compare December 2, 2024 12:54
@homksei
Copy link
Contributor Author

homksei commented Dec 4, 2024

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Dec 4, 2024

rebase

✅ Branch has been successfully rebased

@homksei homksei force-pushed the chore-add-reuse-tool-check branch 2 times, most recently from 45c7cbc to 555980c Compare December 8, 2024 12:20
@homksei homksei force-pushed the chore-add-reuse-tool-check branch 2 times, most recently from ca894bd to 5d22a83 Compare December 8, 2024 13:22
@homksei homksei marked this pull request as ready for review December 8, 2024 13:23
Copy link
Contributor

@icfaust icfaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review mirrors this one: uxlfoundation/scikit-learn-intelex#2215 (review)

Comment on lines 11 to 12
permissions:
contents: read
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
permissions:
contents: read
permissions: read-all

Comment on lines 23 to 24
permissions:
issues: write
pull-requests: write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check can leave comments on the pull request if it finds issues. For this, write permissions need to be granted for these scopes.

@homksei homksei force-pushed the chore-add-reuse-tool-check branch from 55ca631 to dd4a916 Compare December 9, 2024 15:15
@homksei homksei requested a review from a team as a code owner December 9, 2024 15:15
@homksei homksei merged commit d25a720 into uxlfoundation:main Dec 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants