-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add skywalking-eyes
license header check
#2215
Conversation
0bcae7a
to
27e9aa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My review focusses on the github action script, since everything else is conformance. One small question about the linter.
27e9aa7
to
e8a9b15
Compare
e8a9b15
to
511efe4
Compare
on: | ||
pull_request: | ||
branches: | ||
- main | ||
push: | ||
branches: | ||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add same check for release branches too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is not necessary, as release branches are usually created from a commit in the main branch, which should have already been verified by that time.
However, I have added it just in case.
511efe4
to
ec6e062
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its good to go, for extra credit it may be good to test a failure to test the writing function I asked about. (since this and uxlfoundation/oneDAL#2867 don't show one in their PR histories).
0f8c687
to
968e3ec
Compare
968e3ec
to
dfbf1a9
Compare
Description
Added
skywalking-eyes
license header check:.github/workflows/skywalking-eyes.yml
workflow (actually, the check itself).github/.licenserc.yaml
config for checkerAdditionally:
Copyrights in some files were updated:
Updated header for:
.ci/scripts/install_windows.bat
Added license header to the following files:
.github/workflows/renovate-validation.yml
.github/ISSUE_TEMPLATE/-bug_report.md
.github/Pull_Request_template.md
.github/issue_template/Bug_report.md
CODE_OF_CONDUCT.md
README.md
daal4py/README.md
examples/notebooks/README.md
Fixed framing
.rst
files in docs:doc/daal4py/algorithms.rst
doc/daal4py/contents.rst
doc/daal4py/data.rst
...
doc/sources/404.rst
doc/sources/algorithms.rst
doc/sources/array_api.rst
...
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability