Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oneAPI components versions in CI #2958

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

Alexsandruss
Copy link
Contributor

@Alexsandruss Alexsandruss commented Oct 25, 2024

Description

Changes:

  • Update and pin DPC++ compiler and oneAPI runtime libs to 2025
  • MKL-based jobs: update oneMKL to 2025, change oneTBB installation from github to apt and pin compatible version to 2022

PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@Alexsandruss Alexsandruss added infra dependencies Pull requests that update a dependency file labels Oct 25, 2024
@Alexsandruss
Copy link
Contributor Author

/intelci: run

@Alexsandruss Alexsandruss marked this pull request as ready for review October 28, 2024 14:15
@Alexsandruss Alexsandruss requested a review from icfaust October 28, 2024 14:15
Copy link
Contributor

@ahuber21 ahuber21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we expect any changes in Intel CI from these changes in .ci?

@napetrov
Copy link
Contributor

Would we expect any changes in Intel CI from these changes in .ci?

no, in case of those changes. Not sure if this is global rule, like any changes in .ci would impact internal ci.

@napetrov napetrov merged commit 60b20bf into uxlfoundation:main Oct 28, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants