Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update GitHub actions CI linux oneAPI dependencies to reference oneDAL's #2140

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Oct 28, 2024

Description

Match changes occurring in uxlfoundation/oneDAL#2958 which upgrades to the latest Intel DPC++ compiler. The dpcpp compiler cannot be updated in this repository due to the lag in the conda/pip packages used in azure pipelines.

NOTE: In the future, when the compiler is updated in oneDAL, this will break GitHub actions CI until the nightly is rerun. It can be done manually, meaning at most this will cause a 2 hour loss of CI per compiler update. This is a linux-specific issue, as windows uploads and downloads the entire basekit.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@icfaust
Copy link
Contributor Author

icfaust commented Oct 28, 2024

/azp run CI

@icfaust icfaust marked this pull request as ready for review October 28, 2024 09:25
@icfaust
Copy link
Contributor Author

icfaust commented Oct 28, 2024

/azp run CI

@icfaust icfaust marked this pull request as draft October 28, 2024 13:06
@icfaust
Copy link
Contributor Author

icfaust commented Oct 28, 2024

Until AZP is back, I am going to hold off on this PR.

@icfaust icfaust changed the title [CI] Update icx compiler to 2025.0 [CI] Update GitHub actions CI linux oneAPI dependencies to reference oneDAL's Oct 29, 2024
@icfaust icfaust marked this pull request as ready for review October 29, 2024 12:37
@Alexsandruss Alexsandruss merged commit a61bf00 into uxlfoundation:main Oct 30, 2024
30 of 32 checks passed
david-cortes-intel pushed a commit to david-cortes-intel/scikit-learn-intelex that referenced this pull request Oct 31, 2024
…oneDAL's (uxlfoundation#2140)

* Update install_dpcpp.sh

* Update ci.yml

* Update install_dpcpp.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants