-
Notifications
You must be signed in to change notification settings - Fork 173
Refactor sycl header file #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
andrewtbarker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Are there plans for DPC++ to change to sycl/sycl.hpp? Is that part of some SYCL standard?
Minor: did the formatting changes come from clang-format? Is there some version change in clang-format that led to these changes?
sknepper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well! Thanks!
Yes, DPCPP will move to sycl/sycl.hpp as well. It is part of SYCL spec. LLVM compiler already has sycl/sycl.hpp, but it simply points to CL/sycl.hpp. |
mkrainiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
AFAIK, no change in clang-format version. My guess is, those files were not following clang-format initially. |
Description
This PR is refactoring sycl header file by using sycl/sycl.hpp whenever it is available, like in hipSYCL case.
For DPC++ and LLVM, we will start using sycl/sycl.hpp whenever it becomes available.
This PR is fixing #193 and partially fixing #198
Checklist
All Submissions
Tested the below combinations
gen9, mklcpu, mklgpu: blas: all pass
gen9: mklcpu, mklgpu: lapack: I see errors which are not related to this PR. They also exist in develop.
gen9: mklcpu, mklgpu: rng: all pass
nvidia, mklcpu, cublas: blas: all pass
nvidia, mklcpu, cusolver: lapack: all pass
nvidia, mklcpu, curand: rng: all pass
with hipSYCL:
amd, mklcpu, rocblas: blas: all pass
amd, mklcpu, rocrand: rng: all pass except 4 tests. These failures are due to ROCM version. Will be fixed in ROCM 5.1.