-
Notifications
You must be signed in to change notification settings - Fork 173
Fix cuda/hip backend location #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cuda/hip backend location #219
Conversation
|
@yhmtsai Thanks for the PR. Is the description |
|
@mmeterel you are right. I write the wrong folder. |
I think the description is still wrong. The change was moving header files from |
|
Could you please provide the test results with new LLVM compiler? I understand this fixes a compilation issue, but we still want to monitor if there are any functional errors with new compiler version. |
|
Compiling all cublas, cusolver, and curand with testing will lead the error mixed the backend in the tests. oneapi-cuda-blas-test.txt |
@yhmtsai I see the similar errors in my local runs with latest LLVM compiler as well. From the failing tests, it looks like a missing synchronization at first look. Need to look into it deeper. But I verified that, this PR fixes the build issue. Approved. |
|
@mkrainiuk I verified this build fix locally. Could you please take a look? I opened another issue about the failures seen with latest LLVM compiler. #223 |
mkrainiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Looks good to me.
Thanks @mmeterel for verifying it.

Description
From intel/llvm#6407, it moves almost all headers from CL/sycl to sycl
I followed #199 way
make the header can use sycl/* if they exist and allow the old intel llvm.
I also update the CL/sycl.hpp which are not changed before.
All Submissions
Bug fixes
GitHub issue or in this PR)?
Reproduce:
compile the latest intel llvm and this repo, it will not be able to compile due to missing headers.