Musl/linux can not use RTLD_DEEPBIND #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude non-glibc linux systems along with android Fixes src/tbb/dynamic_link.cpp:417:29: error: use of undeclared identifier 'RTLD_DEEPBIND' | flags = flags | RTLD_DEEPBIND; | ^ Signed-off-by: Khem Raj <raj.khem@gmail.com>
| @@ -413,7 +413,7 @@ namespace r1 { | |||
| int flags = RTLD_NOW; | |||
| if (local_binding) { | |||
| flags = flags | RTLD_LOCAL; | |||
| #if __linux__ && !__ANDROID__ && !__TBB_USE_SANITIZERS | |||
There was a problem hiding this comment.
is it possible to have glibc on android ? I believe it is not but did not found and statement in android docs ....
There was a problem hiding this comment.
android = bionic when it comes to C library.
There was a problem hiding this comment.
POSIX.1.2017 does not require RTLD_DEEPBIND for dlopen so it seems to be glibc extension.
kboyarinov
pushed a commit
that referenced
this pull request
Dec 27, 2021
Exclude non-glibc linux systems along with android Fixes src/tbb/dynamic_link.cpp:417:29: error: use of undeclared identifier 'RTLD_DEEPBIND' | flags = flags | RTLD_DEEPBIND; | ^ Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude non-glibc linux systems along with android
Fixes
src/tbb/dynamic_link.cpp:417:29: error: use
of undeclared identifier 'RTLD_DEEPBIND' | flags = flags | RTLD_DEEPBIND;
| ^
Signed-off-by: Khem Raj raj.khem@gmail.com
Description
Add comprehensive description of proposed changes
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information