Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musl/linux can not use RTLD_DEEPBIND #684

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Musl/linux can not use RTLD_DEEPBIND #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tbb/dynamic_link.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ namespace r1 {
int flags = RTLD_NOW;
if (local_binding) {
flags = flags | RTLD_LOCAL;
#if __linux__ && !__ANDROID__ && !__TBB_USE_SANITIZERS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to have glibc on android ? I believe it is not but did not found and statement in android docs ....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android = bionic when it comes to C library.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POSIX.1.2017 does not require RTLD_DEEPBIND for dlopen so it seems to be glibc extension.

#if (__linux__ && __GLIBC__) && !__TBB_USE_SANITIZERS
flags = flags | RTLD_DEEPBIND;
#endif
} else {
Expand Down