Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: DBSCAN via Array API #2014

Closed

Conversation

samir-nasibli
Copy link
Contributor

@samir-nasibli samir-nasibli commented Aug 27, 2024

Description

Will make this PR depend on #2096 and going to leave here only DBSCAN specific updates
Includes some changes from #1813

TODO

dispatch mechanism and tests suits will be updated


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

updated onedal4py _device_offload module

sklearnex _device_oflload depends on onedal4py only
@samir-nasibli samir-nasibli added the enhancement New feature or request label Sep 17, 2024
@samir-nasibli samir-nasibli mentioned this pull request Oct 8, 2024
13 tasks
requirements-test.txt Outdated Show resolved Hide resolved
@samir-nasibli
Copy link
Contributor Author

This PR was decomposed into two pull requests #2096 and #2100
Closing this one.

@samir-nasibli samir-nasibli deleted the enh/dbscan_array_api branch October 10, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant