-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap migration feature branch #9117
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request
|
…ltiple deployment modes" This reverts commit 167256f.
* Fix setup wizard alignment issues * Fix http proxy setup page * Fix image alignment
* Add ui debug page controller * Add build time tooling to bundle stories * Add ui debug page frontend * Add missing types * Migrate all stories, refactor directory structure * Fix lint * Add changes
…ltiple deployment modes" This reverts commit 0113002.
8836640
to
bbb1590
Compare
…ltiple deployment modes" This reverts commit 67568af.
Fyi there's no point in reviewing this PR by itself, it's a massive aggregate of other PRs that are already either reviewed or superseded by other branches. |
Note to @deneb-alpha: it would probably be best to squash this when merging, since this branch has a lot of merge-revert-fix-etc for handling all the incoming pull request and testing in the feature branch. |
* Fix custom column classes in the updated theme * Fix missing leading slash in search pathname * Fix alert layout in formula catalog in the updated theme * Fix layout mismatch in patches management * Improved viewport size check * Refactor deployment to remove code duplication and support multiple deployment modes * Fixed stretched button issue * Fix input addon sizing * Refactor deployment to remove code duplication and support multiple deployment modes * Migrate HTTP proxy, fix setup wizard layout issues (uyuni-project#9162) * Fix setup wizard alignment issues * Fix http proxy setup page * Fix image alignment * Initial migration work for CLM pages * Fix form group offset * Hard integrate UI stories (uyuni-project#9220) * Add ui debug page controller * Add build time tooling to bundle stories * Add ui debug page frontend * Add missing types --------- Co-authored-by: Thomas Florio <thomas.florio@suse.com> Co-authored-by: Richa <richa.bisht@suse.com>
What does this PR change?
Part of https://github.com/SUSE/spacewalk/issues/18940
This PR gathers up UI fixes from different PRs and branches.
#8844
#8845
#8846
#8847
#8948
#9111
#9162
#8951
#9220
GUI diff
Affects many, many pages all over the place.
Documentation
Documentation issue already exists.
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: UI work.
DONE
Links
Part of https://github.com/SUSE/spacewalk/issues/18940
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!