Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable patch and package install and monitoring for sl micro minions #9277

Closed
wants to merge 1 commit into from
Closed

Disable patch and package install and monitoring for sl micro minions #9277

wants to merge 1 commit into from

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Sep 18, 2024 •
edited
Loading

What does this PR change?

Disable patch and package install and monitoring for sl micro minions in BV smoke test.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: already covered

  • DONE

Links

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@maximenoel8 maximenoel8 requested a review from a team as a code owner September 18, 2024 13:36
@maximenoel8 maximenoel8 self-assigned this Sep 18, 2024
Bischoff
Bischoff approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

too bad we don't have bscs to reference for the other problems than prometheus?

@maximenoel8 maximenoel8 added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Sep 20, 2024
@srbarrios
Copy link
Member

Could we please explain why installation of packages and applying patches is disabled?

srbarrios
srbarrios previously requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please discuss it in Slack before merging? Thank you. 🙏🏻

@srbarrios srbarrios dismissed their stale review September 24, 2024 08:27

After discussing it here https://suse.slack.com/archives/C02D12TNYLS/p1727154299606569 I will remove my request for changes.

@Bischoff Bischoff self-requested a review September 24, 2024 09:50
Bischoff
Bischoff requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be the situation has changed , see latest remarks from Abid about the exporter

Please do not merge yet, we need to discuss

@srbarrios
Copy link
Member

Related to this, our images configured through cloud-init, should have now packages and patches available after the deployment, thanks to this refactor uyuni-project/sumaform#1702

srbarrios
srbarrios reviewed Sep 24, 2024
View reviewed changes
testsuite/features/build_validation/smoke_tests/smoke_tests.template
Comment on lines +179 to +180
@skip_for_sl_micro
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Copy link
Member

@srbarrios srbarrios Sep 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack, I would personally show a red in this test case on the test report, unless this affects other test cases.
Otherwise, the test report is not reflecting the current product state, where a product bug has been reported.

srbarrios
srbarrios reviewed Sep 24, 2024
View reviewed changes
testsuite/features/build_validation/smoke_tests/smoke_tests.template
# workaround for SLE Micro minion issue bsc#1209374
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

srbarrios
srbarrios reviewed Sep 24, 2024
View reviewed changes
testsuite/features/build_validation/smoke_tests/smoke_tests.template
Scenario: Enable and start Prometheus Node Exporter service
And I start the "prometheus-node_exporter.service" service on "<client>"
And I enable the "prometheus-node_exporter.service" service on "<client>"

@skip_for_sle_micro_ssh_minion
@skip_for_sl_micro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

srbarrios
srbarrios reviewed Sep 24, 2024
View reviewed changes
testsuite/features/build_validation/smoke_tests/smoke_tests.template
Comment on lines +240 to +241
@skip_for_sl_micro
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip looks good to me, but that's unrelated to the commented bugs.
Apache and Postgres components are not meant to be installed directly on SL Micro, so that's the reason why we don't support these exporters in the product, that's unrelated to Node Exporter which just collects HW metrics.

srbarrios
srbarrios reviewed Sep 24, 2024
View reviewed changes
testsuite/features/build_validation/smoke_tests/smoke_tests.template
Comment on lines +250 to +251
@skip_for_sl_micro
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, I would not skip it.

srbarrios
srbarrios reviewed Sep 24, 2024
View reviewed changes
testsuite/features/build_validation/smoke_tests/smoke_tests.template
Comment on lines 56 to +59
@skip_for_debianlike
@skip_for_rocky9
@skip_for_alma9
@skip_for_sl_micro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be skipping them, this is a supported feature.
Instead, we need to find a way to cover this with a patch, if none available now.

srbarrios
srbarrios reviewed Sep 24, 2024
View reviewed changes
testsuite/features/build_validation/smoke_tests/smoke_tests.template
Comment on lines 73 to +74
@skip_for_sle_micro_ssh_minion
@skip_for_sl_micro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be skipping them, this is a supported feature for SL/SLE Micro.
Instead, we need to find a way to cover this with a package, if none available now.

Hopefully this PR will help on this uyuni-project/sumaform#1702

@maximenoel8 maximenoel8 removed the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srbarrios srbarrios srbarrios left review comments

@Bischoff Bischoff Bischoff requested changes

Assignees

@maximenoel8 maximenoel8

Labels
build-validation-features ruby_rubocop testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximenoel8 @srbarrios @Bischoff