Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable patch and package install and monitoring for sl micro minions #9277

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ Feature: Smoke tests for <client>
@skip_for_debianlike
@skip_for_rocky9
@skip_for_alma9
@skip_for_sl_micro
Comment on lines 56 to +59
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be skipping them, this is a supported feature.
Instead, we need to find a way to cover this with a patch, if none available now.

Scenario: Install a patch on the <client>
Given I am on the Systems overview page of this "<client>"
When I follow "Software" in the content area
Expand All @@ -70,6 +71,7 @@ Feature: Smoke tests for <client>
And I reboot the "<client>" if it is a transactional system

@skip_for_sle_micro_ssh_minion
@skip_for_sl_micro
Comment on lines 73 to +74
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be skipping them, this is a supported feature for SL/SLE Micro.
Instead, we need to find a way to cover this with a package, if none available now.

Hopefully this PR will help on this uyuni-project/sumaform#1702

Scenario: Install a package on the <client>
Given I am on the Systems overview page of this "<client>"
When I follow "Software" in the content area
Expand Down Expand Up @@ -174,6 +176,8 @@ Feature: Smoke tests for <client>
And I wait until event "Package Install/Upgrade scheduled by <client>" is completed

@skip_for_sle_micro_ssh_minion
@skip_for_sl_micro
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Comment on lines +179 to +180
Copy link
Member

@srbarrios srbarrios Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack, I would personally show a red in this test case on the test report, unless this affects other test cases.
Otherwise, the test report is not reflecting the current product state, where a product bug has been reported.

Scenario: Enable Prometheus Node exporter formula on the <client>
Given I am on the Systems overview page of this "<client>"
When I follow "Formulas" in the content area
Expand All @@ -191,6 +195,8 @@ Feature: Smoke tests for <client>
Then I should see a "Formula saved" text

@skip_for_sle_micro
@skip_for_sl_micro
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Scenario: Enable Prometheus Apache and Postgres exporter formula on the <client>
Given I am on the Systems overview page of this "<client>"
When I follow "Formulas" in the content area
Expand All @@ -203,6 +209,8 @@ Feature: Smoke tests for <client>
Then I should see a "Formula saved" text

@skip_for_sle_micro_ssh_minion
@skip_for_sl_micro
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Scenario: Apply highstate for the Prometheus exporters on the <client>
Given I am on the Systems overview page of this "<client>"
When I follow "States" in the content area
Expand All @@ -214,17 +222,23 @@ Feature: Smoke tests for <client>

@skip_for_sle_micro_ssh_minion
@sle_micro_minion
@skip_for_sl_micro
# workaround for SLE Micro minion issue bsc#1209374
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Scenario: Enable and start Prometheus Node Exporter service
And I start the "prometheus-node_exporter.service" service on "<client>"
And I enable the "prometheus-node_exporter.service" service on "<client>"

@skip_for_sle_micro_ssh_minion
@skip_for_sl_micro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Scenario: Visit Node monitoring endpoint on the <client>
When I wait until "node" exporter service is active on "<client>"
And I visit "Prometheus node exporter" endpoint of this "<client>"

@skip_for_sle_micro
@skip_for_sl_micro
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Comment on lines +240 to +241
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skip looks good to me, but that's unrelated to the commented bugs.
Apache and Postgres components are not meant to be installed directly on SL Micro, so that's the reason why we don't support these exporters in the product, that's unrelated to Node Exporter which just collects HW metrics.

Scenario: Visit Apache and Postgres monitoring endpoint on the <client>
When I wait until "apache" exporter service is active on "<client>"
And I visit "Prometheus apache exporter" endpoint of this "<client>"
Expand All @@ -233,6 +247,8 @@ Feature: Smoke tests for <client>

@skip_for_sle_micro_ssh_minion
@monitoring_server
@skip_for_sl_micro
# WORKAROUND for SL Micro because of bsc#1227451 and bsc#1229567
Comment on lines +250 to +251
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, I would not skip it.

Scenario: The data from <client> appear on Grafana dashboard
When I visit the grafana dashboards of this "monitoring_server"
And I wait until I do not see "Loading Grafana" text
Expand Down