Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing notification message for recurring states #9523

Merged

Conversation

parlt91
Copy link
Contributor

@parlt91 parlt91 commented Nov 27, 2024

What does this PR change?

When updating state assignments a 'State assignments have been saved.' message would be shown that could confuse users that their changes are already persistet and clicking the 'Update Schedule' button is not needed.

Remove the above message to avoid this kind of confusion. The message will still be shown if the component is used from the 'Configuration Channels' UI where clicking the 'Confirm' button actually persists the changes in the database.

GUI diff

  • DONE

Documentation

  • No documentation needed

  • DONE

Test coverage

  • Cucumber tests were adjusted

  • DONE

Links

Issue(s): #

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

When updating state assignments a 'State assignments have been saved.'
message would be shown that could confuse users that their changes are
already persistet and clicking the 'Update Schedule' button is not
needed.

Remove the above message to avoid this kind of confusion.
The message will still be shown if the component is used from the
'Configuration Channels' UI where clicking the 'Confirm' button
actually persists the changes in the database.

Signed-off-by: Pascal Arlt <parlt@suse.com>
@parlt91 parlt91 requested review from a team as code owners November 27, 2024 14:36
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9523/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9523/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@parlt91 parlt91 merged commit b65f8c2 into uyuni-project:master Dec 4, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants