Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing notification message for recurring states #9523

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove confusing notification message for recurring states #9523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions testsuite/features/secondary/min_recurring_action.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ Feature: Recurring Actions
And I click on "Save Changes"
And I wait until I see "Edit State Ranks" text
And I click on "Confirm"
And I wait until I see "State assignments have been saved." text
And I click on "Create Schedule"
Then I wait until I see "Schedule successfully created" text
And I should see a "IP forwarding custom state recurring action" text
Expand All @@ -56,7 +55,6 @@ Feature: Recurring Actions
And I click on "Save Changes"
And I wait until I see "Edit State Ranks" text
And I click on "Confirm"
And I wait until I see "State assignments have been saved" text
And I click on "Update Schedule"
Then I wait until I see "Schedule successfully updated" text
And I should see a "custom_state_schedule_name_changed" text
Expand Down
5 changes: 4 additions & 1 deletion web/html/src/components/states-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,10 @@ class StatesPicker extends React.Component<StatesPickerProps, StatesPickerState>
}
});

messages = messages.concat(MessagesUtils.info(t("State assignments have been saved.")));
messages =
this.props.type === "state"
? messages
: messages.concat(MessagesUtils.info(t("State assignments have been saved.")));
this.setState({
changed: new Map(), // clear changed
// Update the channels with the new data
Expand Down
Loading