Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove migration and listmonk setup #4344

Merged
merged 10 commits into from
Nov 5, 2024
Merged

chore: remove migration and listmonk setup #4344

merged 10 commits into from
Nov 5, 2024

Conversation

sjschlapbach
Copy link
Member

@sjschlapbach sjschlapbach commented Oct 31, 2024

Summary by CodeRabbit

  • New Features

    • No new features introduced.
  • Bug Fixes

    • No bug fixes implemented.
  • Documentation

    • Updated README to reflect that KlickerUZH v2.0 is no longer publicly available.
    • Removed migration guidance documentation.
  • Chores

    • Removed several configuration files related to migration processes and Listmonk integration.
    • Updated localization files to remove migration-related keys.
    • Removed environment variables and tasks related to migration from configuration files.
  • Refactor

    • Removed migration-related GraphQL mutations and services, streamlining the application.
    • Eliminated MongoDB service configurations and related environment variables across multiple files.

Copy link

aviator-app bot commented Oct 31, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link

coderabbitai bot commented Oct 31, 2024

Warning

Rate limit exceeded

@rschlaefli has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 55f35f6 and e768a23.

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

This pull request introduces significant changes primarily focused on the removal of migration-related functionalities and configurations across various components of the KlickerUZH application. Notable deletions include GitHub Actions workflows for TypeScript checks, Azure Functions configurations, and migration-related files. Additionally, several environment variables and configurations associated with Listmonk and MongoDB have been eliminated. The changes reflect a shift away from migration processes, impacting both the application’s backend and frontend components, including localization files and GraphQL schemas.

Changes

File Change Summary
.github/workflows/check-types.yml Removed steps for checking TypeScript types for func-migration-v2-export and func-migration-v3-import.
.github/workflows/v3_klickeruzhprod-migration-export.yml File deleted; previously defined a workflow for deploying func-migration-v2-export.
.github/workflows/v3_klickeruzhprod-migration-import.yml File deleted; previously defined a workflow for deploying klickeruzhprod-migration-import.
.versionrc.js Removed entries for func-migration-v2-export and func-migration-v3-import from bumpFiles.
.vscode/settings.json Removed properties related to Azure Functions deployment configuration.
README.md Updated text regarding the availability of KlickerUZH v2.0; minor formatting changes.
_run_migration_services.sh File deleted; previously initiated Docker services for migration.
apps/docs/docs/getting_started/migration.mdx File deleted; contained migration guidance from v2.0 to v3.0.
apps/docs/sidebars.js Removed entry for migration from the sidebar; commented out sections for 'Advanced Topics' and 'About'.
apps/frontend-manage/src/components/common/Header.tsx Removed Navigation.ButtonItem linking to migration page.
apps/frontend-manage/src/lib/utils/migrationLinkTemplate.html File deleted; previously an HTML template for migration emails.
apps/frontend-manage/src/pages/migration.tsx File deleted; managed multi-step migration process.
apps/func-migration-v2-export/.funcignore File deleted; defined patterns for Azure Functions tooling.
apps/func-migration-v2-export/.gitignore File deleted; specified ignored patterns for Git.
apps/func-migration-v2-export/host.json File deleted; contained Azure Functions configuration settings.
apps/func-migration-v2-export/local.settings.template File deleted; defined development environment settings for Azure Functions.
apps/func-migration-v2-export/package.json File deleted; metadata and dependencies for func-migration-v2-export.
apps/func-migration-v2-export/src/*.ts Multiple files deleted; removed functions related to Azure Blob Storage, MongoDB, and utility functions.
apps/func-migration-v3-import/*.yml Multiple files deleted; similar to v2, removed configurations and functions related to migration.
deploy/azure/index.ts Removed Cosmos DB instance configuration.
deploy/charts/klicker-uzh-v2/templates/cm-backend-graphql.yaml Removed several key-value pairs from ConfigMap related to Listmonk.
deploy/charts/klicker-uzh-v2/templates/secret-backend-graphql.yaml Removed several secrets related to migration and Listmonk.
deploy/charts/klicker-uzh-v2/values.yaml Removed migration and Listmonk configuration sections.
docker-compose.yml Removed MongoDB and Listmonk services from the configuration.
email/*.html Multiple email templates deleted; related to migration notifications.
package.json Updated version and removed dev:migration script; added engine specifications.
packages/graphql/package.json Removed mongodb dependency; updated version.
packages/graphql/src/graphql/ops/*.graphql Removed migration-related mutations.
packages/graphql/src/lib/mongo.ts Deleted MongoDB connection handling functionality.
packages/graphql/src/lib/util.ts Removed function for sending email notifications via Listmonk.
packages/graphql/src/schema/mutation.ts Removed migration-related mutation fields.
packages/graphql/src/services/migration.ts Deleted functions handling migration requests and token generation.
packages/i18n/messages/*.ts Removed migration-related keys and updated various localization strings.
turbo.json Removed environment variables related to Listmonk and the dev:migration task.
util/listmonk-config.toml Deleted configuration file for Listmonk settings.

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cypress bot commented Oct 31, 2024

klicker-uzh    Run #3556

Run Properties:  status check passed Passed #3556  •  git commit caa6f312aa ℹ️: Merge e768a2387a8680032b3fe7c091f69128218589b7 into 7a734d11aae77ae306c951388b8a...
Project klicker-uzh
Branch Review remove-migration
Run status status check passed Passed #3556
Run duration 11m 19s
Commit git commit caa6f312aa ℹ️: Merge e768a2387a8680032b3fe7c091f69128218589b7 into 7a734d11aae77ae306c951388b8a...
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 140
View all changes introduced in this branch ↗︎

Copy link

gitguardian bot commented Oct 31, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
1623504 Triggered Username Password a616e40 deploy/compose-traefik-proxy/klicker/services.env View secret
1509424 Triggered Generic Password a616e40 deploy/compose/docker-compose.yml View secret
1509424 Triggered Generic Password a616e40 docker-compose.yml View secret
1509424 Triggered Generic Password a616e40 deploy/compose/docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments.

Actionable comments posted: 1

🛑 Comments failed to post (1)
README.md (1)

5-5: ⚠️ Potential issue

Fix spelling: "publically" → "publicly".

The word "publically" is not commonly used. The standard spelling is "publicly".

Apply this diff to fix the spelling:

-> Please navigate to the [dev branch](https://github.com/uzh-bf/klicker-uzh/tree/dev) for the older [KlickerUZH v2.0](https://app.klicker.uzh.ch/), which is not publically available anymore.
+> Please navigate to the [dev branch](https://github.com/uzh-bf/klicker-uzh/tree/dev) for the older [KlickerUZH v2.0](https://app.klicker.uzh.ch/), which is not publicly available anymore.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

> Please navigate to the [dev branch](https://github.com/uzh-bf/klicker-uzh/tree/dev) for the older [KlickerUZH v2.0](https://app.klicker.uzh.ch/), which is not publicly available anymore.
🧰 Tools
🪛 LanguageTool

[style] ~5-~5: The adverb “publically” isn’t commonly used. Consider using the shorter “publicly”.
Context: ...ps://app.klicker.uzh.ch/), which is not publically available anymore. klicker-uzh is th...

(PUBLICALLY)

@rschlaefli rschlaefli enabled auto-merge (squash) November 5, 2024 20:01
Copy link

sonarqubecloud bot commented Nov 5, 2024

@rschlaefli rschlaefli merged commit 160da70 into v3 Nov 5, 2024
14 checks passed
@rschlaefli rschlaefli deleted the remove-migration branch November 5, 2024 20:22
Copy link

cypress bot commented Nov 5, 2024

klicker-uzh    Run #3557

Run Properties:  status check passed Passed #3557  •  git commit 160da70101: chore: remove migration and listmonk setup (#4344)
Project klicker-uzh
Branch Review v3
Run status status check passed Passed #3557
Run duration 11m 16s
Commit git commit 160da70101: chore: remove migration and listmonk setup (#4344)
Committer Julius Schlapbach
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 140
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants