Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing date (time) picker and adding it back in the dom resets the display pattern #105

Closed
vaadin-miki opened this issue May 7, 2020 · 0 comments · Fixed by #106
Closed

Removing date (time) picker and adding it back in the dom resets the display pattern #105

vaadin-miki opened this issue May 7, 2020 · 0 comments · Fixed by #106
Assignees
@vaadin-miki
Labels
bug Something isn't working
Milestone
0.6.1 - Release p...

Comments

@vaadin-miki
Copy link
Owner

vaadin-miki commented May 7, 2020 •
edited
Loading

Once a component is created and added to DOM, it cannot be removed without losing the date display pattern,

Steps to reproduce:

  1. Create a super date (time) picker and set its display pattern to something.
  2. Display the component, then remove it from dom and add it back.
  3. Notice the display pattern reset.

Expected: date display pattern stays unchanged.
@vaadin-miki vaadin-miki self-assigned this May 7, 2020
@vaadin-miki vaadin-miki added the bug Something isn't working label May 7, 2020
@vaadin-miki vaadin-miki added this to the Next release milestone May 7, 2020
@vaadin-miki vaadin-miki changed the title Navigating to a different view resets date pattern Removing date (time) picker and adding it back in the dom resets the display pattern May 7, 2020
vaadin-miki added a commit that referenced this issue May 7, 2020
@vaadin-miki
#105 fixed
daf5b53
@vaadin-miki vaadin-miki mentioned this issue May 7, 2020
Merged
vaadin-miki added a commit that referenced this issue May 7, 2020
@vaadin-miki
#105 fixed
85009d5
vaadin-miki added a commit that referenced this issue May 25, 2020
@vaadin-miki
Release 0.6.1 ready (#121)
780e677 
release 0.6.1 with #100 #105 #108 #107 #111 #113 #115 #119
vaadin-miki added a commit that referenced this issue May 29, 2020
@vaadin-miki
Release 0.6.2 ready (#130)
511d16e 
done #100 #105 #108 #110 #107 #111 #113 #115 #117 #119 #22 #124 #126 #127 #129
vaadin-miki added a commit that referenced this issue Jun 22, 2020
@vaadin-miki
Release 0.7.0 ready (#169)
be67db6 
done #100 #105 #108 #107 #111 #113 #115 #117 #119 #22 #124 #126 #127 #129 #132 #122 #136 #137 #123 #141 #139 #143 #135 #146 #147 #152 #154 #131 #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
bug Something isn't working
Projects
None yet
Milestone
0.6.1 - Release process improvement
Development

Successfully merging a pull request may close this issue.

#105 fixed vaadin-miki/super-fields
1 participant
@vaadin-miki