Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setReadOnly has no effect on number fields #136

Closed
vaadin-miki opened this issue Jun 2, 2020 · 1 comment · Fixed by #138
Closed

setReadOnly has no effect on number fields #136

vaadin-miki opened this issue Jun 2, 2020 · 1 comment · Fixed by #138
Assignees
@vaadin-miki
Labels
bug Something isn't working
Milestone
0.7.0 - SuperText...

Comments

@vaadin-miki
Copy link
Owner

Having a read-only field should disable the text input.
@vaadin-miki vaadin-miki self-assigned this Jun 2, 2020
@vaadin-miki vaadin-miki added the bug Something isn't working label Jun 2, 2020
@vaadin-miki vaadin-miki added this to the 0.7.0 - SuperTextField milestone Jun 2, 2020
@vaadin-miki
Copy link
Owner Author

This is caused by not delegating the readOnly flag to the text input.

vaadin-miki added a commit that referenced this issue Jun 2, 2020
@vaadin-miki
#136 done
c50f655 
some more methods are now delegated properly to the text field
@vaadin-miki vaadin-miki mentioned this issue Jun 2, 2020
Merged
vaadin-miki added a commit that referenced this issue Jun 2, 2020
@vaadin-miki
Merge pull request #138 from vaadin-miki/136-fixed-setreadonly-for-nu…
396c8fe 
…mber-fields

#136 done
vaadin-miki added a commit that referenced this issue Jun 22, 2020
@vaadin-miki
Release 0.7.0 ready (#169)
be67db6 
done #100 #105 #108 #107 #111 #113 #115 #117 #119 #22 #124 #126 #127 #129 #132 #122 #136 #137 #123 #141 #139 #143 #135 #146 #147 #152 #154 #131 #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
bug Something isn't working
Projects
None yet
Milestone
0.7.0 - SuperTextField
Development

Successfully merging a pull request may close this issue.

#136 done vaadin-miki/super-fields
1 participant
@vaadin-miki