Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component added to read-only layout is not read-only #403

Closed
vaadin-miki opened this issue Sep 14, 2022 · 0 comments · Fixed by #405
Closed

Component added to read-only layout is not read-only #403

vaadin-miki opened this issue Sep 14, 2022 · 0 comments · Fixed by #405
Assignees
@vaadin-miki
Labels
bug Something isn't working
Milestone
0.14.1 - SuperChe...

Comments

@vaadin-miki
Copy link
Owner

vaadin-miki commented Sep 14, 2022 •
edited
Loading

If a layout implements HasReadOnly, any component added while it is read-only, should result in the component being switched to read-only as well.

However, if a layout is not read-only, adding read-only component should not switch the state off.
@vaadin-miki vaadin-miki added the bug Something isn't working label Sep 14, 2022
@vaadin-miki vaadin-miki added this to the Next release milestone Sep 14, 2022
@vaadin-miki vaadin-miki self-assigned this Sep 14, 2022
vaadin-miki added a commit that referenced this issue Sep 14, 2022
@vaadin-miki
#403 fixed
d359b8c
@vaadin-miki vaadin-miki mentioned this issue Sep 14, 2022
Merged
vaadin-miki added a commit that referenced this issue Sep 14, 2022
@vaadin-miki
#402 #403 #404 done (#405)
d4406ef 
fixed layout bugs, added SuperCheckbox
vaadin-miki added a commit that referenced this issue Sep 15, 2022
@vaadin-miki @dependabot @github-actions
Release 0.14.1 ready (#411)
2922a06 
* #400 #406 #408 #402 #403 #404 done (#405)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vaadin-miki <vaadin-miki@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
bug Something isn't working
Projects
None yet
Milestone
0.14.1 - SuperCheckbox and bugfixes
Development

Successfully merging a pull request may close this issue.

#402 #403 #404 done vaadin-miki/super-fields
1 participant
@vaadin-miki