Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip is not working in SuperLongField #448

Closed
jcgueriaud1 opened this issue Dec 13, 2022 · 2 comments · Fixed by #455
Closed

Tooltip is not working in SuperLongField #448

jcgueriaud1 opened this issue Dec 13, 2022 · 2 comments · Fixed by #455
Assignees
Labels
bug Something isn't working

Comments

@jcgueriaud1
Copy link
Contributor

In Vaadin 23.3, there is a new Tooltip component.
A SuperLongField is extending CustomField that implements HasTooltip.
When I'm trying to set the tooltip, the tooltip is created as a component but the tooltip overlay is not created.

@jcgueriaud1
Copy link
Contributor Author

Ok, it's because the tooltip should be attached to the inner field.

In AbstractSuperNumberField, if I add this:


    @Override
    public Tooltip setTooltipText(String text) {
        return field.setTooltipText(text);
    }

    @Override
    public Tooltip getTooltip() {
        return field.getTooltip();
    }

It's working as expected.

@vaadin-miki
Copy link
Owner

@jcgueriaud1 thanks JC! will add that to the next release

I think superfields still rely on 23.2, but will upgrade it soon

@vaadin-miki vaadin-miki self-assigned this Dec 19, 2022
@vaadin-miki vaadin-miki added the bug Something isn't working label Dec 19, 2022
@vaadin-miki vaadin-miki added this to the Next release milestone Dec 19, 2022
@jcgueriaud1 jcgueriaud1 mentioned this issue Jan 26, 2023
vaadin-miki pushed a commit that referenced this issue Jan 27, 2023
* Bump the vaadin version to the latest 23.3
Fix the tooltip for the abstractnumberfield
Add WithTooltipMixin interface
Clean up the pom xml
Remove the deprecated setPreventInvalidInput

* Remove the deprecated setPreventInvalidInput

* Revert the setPreventInvalidInput

Author: @jcgueriaud1
vaadin-miki added a commit that referenced this issue Jan 27, 2023
removed all traces of heroku in the docs
vaadin-miki added a commit that referenced this issue Jan 27, 2023
* #456 Bump the vaadin version to the latest 23.3
* Fix the tooltip for the abstractnumberfield
* Add WithTooltipMixin interface
* Clean up the pom xml
* #448 tooltip should now work
* removed all traces of heroku in the docs
* ignoring more than just *.ts in frontend/generated
* Javascript error in custom field (#452)
* #454 hopefully done

Co-authored-by: Jean-Christophe Gueriaud <51313578+jcgueriaud1@users.noreply.github.com>
vaadin-miki added a commit that referenced this issue Jan 31, 2023
#440 #437 #443 #445 #448 #451 #454 #456 done

Co-authored-by: Jean-Christophe Gueriaud <51313578+jcgueriaud1@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vaadin-miki <vaadin-miki@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jean-Christophe Gueriaud <51313578+jcgueriaud1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants