Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript error when SuperLongFIeld is used in a customfield #451

Closed
jcgueriaud1 opened this issue Jan 26, 2023 · 0 comments · Fixed by #455
Closed

Javascript error when SuperLongFIeld is used in a customfield #451

jcgueriaud1 opened this issue Jan 26, 2023 · 0 comments · Fixed by #455

Comments

@jcgueriaud1
Copy link
Contributor

There is an issue when the SuperLongField is validated and it's used in a customfield:
checkValidity is undefined

Here is a demo page to reproduce it:


@Route(value = "test")
@PageTitle("SuperFields - Demo App")
public class TestPage extends VerticalLayout {

    public TestPage() {
        add(new CustomSuperLongField());
    }


    public static class CustomSuperLongField extends CustomField<Long> {

        private SuperLongField longField;

        public CustomSuperLongField() {
            add(longField = new SuperLongField());
        }

        @Override
        protected Long generateModelValue() {
            return longField.getValue();
        }

        @Override
        protected void setPresentationValue(Long value) {
            longField.setValue(value);
        }
    }
}

Then enter something in the field and blur it, you should have a javascript error.

vaadin-miki added a commit that referenced this issue Jan 27, 2023
* #456 Bump the vaadin version to the latest 23.3
* Fix the tooltip for the abstractnumberfield
* Add WithTooltipMixin interface
* Clean up the pom xml
* #448 tooltip should now work
* removed all traces of heroku in the docs
* ignoring more than just *.ts in frontend/generated
* Javascript error in custom field (#452)
* #454 hopefully done

Co-authored-by: Jean-Christophe Gueriaud <51313578+jcgueriaud1@users.noreply.github.com>
vaadin-miki added a commit that referenced this issue Jan 31, 2023
#440 #437 #443 #445 #448 #451 #454 #456 done

Co-authored-by: Jean-Christophe Gueriaud <51313578+jcgueriaud1@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vaadin-miki <vaadin-miki@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jean-Christophe Gueriaud <51313578+jcgueriaud1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant