Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TestBench to Jakarta EE 9 / Servlet 5.0 #14784

Closed
4 tasks done
mshabarov opened this issue Oct 10, 2022 · 4 comments
Closed
4 tasks done

Migrate TestBench to Jakarta EE 9 / Servlet 5.0 #14784

mshabarov opened this issue Oct 10, 2022 · 4 comments

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Oct 10, 2022

  • change sources to use Servlet 5.0 API, convert packages to jakarta.*
  • use JDK 17 as a minimum
  • create CI builds: 9.0 branch, snapshot validation build and release build
  • migrate to JUnit 5
@knoobie
Copy link
Contributor

knoobie commented Oct 10, 2022

And Junit5? ;)

@mshabarov
Copy link
Contributor Author

Thanks @knoobie , that's a hot topic indeed. I'd include JUnit 5 into this scope as well.

@MarcinVaadin MarcinVaadin self-assigned this Oct 10, 2022
MarcinVaadin added a commit to vaadin/testbench that referenced this issue Oct 10, 2022
@MarcinVaadin
Copy link
Member

As for CI builds - TestBench CI uses single job for running all branches/PRs builds. It will be updated to include maven compiler version property for each build separately, nothing more to be done.

@MarcinVaadin
Copy link
Member

As for JUnit5 - common part has been extracted as a part of vaadin/testbench#1318, I've did the same based on current master.

Classes to be migrated to JUnit5:

MarcinVaadin added a commit to vaadin/testbench that referenced this issue Oct 13, 2022
MarcinVaadin added a commit to vaadin/testbench that referenced this issue Oct 14, 2022
* feat: Jakarta EE 9

Fixes: vaadin/flow#14784

* chore: flow and jetty bump

* chore: vaadin-spring version bump

* chore: apache snapshots repo

* chore: user proper license-checker version in integration-tests

* chore: lit template update

* chore: apache snapshots repo justification comment

* Apply suggestions from code review

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>

* chore: license-checker bump

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
(cherry picked from commit ae748f1)
mshabarov added a commit to vaadin/testbench that referenced this issue Oct 20, 2022
Fixes: vaadin/flow#14784

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
@MarcinVaadin MarcinVaadin removed their assignment Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants