Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Jakarta EE 9 (Vaadin 24 6WP) #1541

Closed
wants to merge 15 commits into from
Closed

Conversation

MarcinVaadin
Copy link
Member

Implementation of: vaadin/flow#14784

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2022

CLA assistant check
All committers have signed the CLA.

@MarcinVaadin
Copy link
Member Author

What has been done:

  1. Separation of common classes to vaadin-testbench-shared
  2. Added vaadin-testbench-core-junit5
  • Removed parallel scheduler in favor of native JUnit5 parallel support
  • DesiredCapabilities features extracted to new package
  • Multiple capabilities are now run using TestTemplates with InvocationContextProvider
  • Rules converted to Extensions
  1. Added vaadin-integration-tests-junit5 that are using new approach
  • Parallel runs configured

What needs to be done still:

  1. Implement RetryRule feature in JUnit5 way

Migration notes:

  1. Update imports to org.junit.jupiter.api.
  2. Annotate test method with @TestBenchTest (name to be discussed) instead of @Test
  3. Extend AbstractJUnit5TB6Test instead of AbstractTB6Test

@MarcinVaadin MarcinVaadin deleted the feature/jakarta-servlet5 branch October 14, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants