Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract common classes to vaadin-testbench-shared #1550

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

MarcinVaadin
Copy link
Member

@MarcinVaadin MarcinVaadin commented Oct 13, 2022

Description

Resurrection of #1318 on latest master

Fixes: #1363

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@MarcinVaadin MarcinVaadin changed the title feature: extract common parts to vaadin-testbench-shared feat: extract common classes to vaadin-testbench-shared Oct 13, 2022
@MarcinVaadin
Copy link
Member Author

MarcinVaadin commented Oct 14, 2022

First run of CI tests often fails - downloading artifacts, building frontend. But second run on same agent is green.

From build log:

[09:11:27][INFO]  T E S T S
[09:11:27][INFO] -------------------------------------------------------
[09:11:27][INFO] Running com.vaadin.tests.PerformanceIT
[09:11:27][WARNING] Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.386 s - in com.vaadin.tests.PerformanceIT
[09:11:27][INFO] Running com.vaadin.tests.elements.ElementScreenCompareIT
[09:11:47]  
[09:11:47] ------------------ Starting Frontend compilation. ------------------
[09:11:48]  
[09:11:48] ----------------- Frontend compiled successfully. -----------------
[09:11:48]  
[09:11:56][ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 28.319 s <<< FAILURE! - in com.vaadin.tests.elements.ElementScreenCompareIT
[09:11:56][ERROR] elementCompareScreen[Windows_Chrome_](com.vaadin.tests.elements.ElementScreenCompareIT)  Time elapsed: 28.313 s  <<< ERROR!
[09:11:56]org.openqa.selenium.NoSuchElementException:
[09:11:56]No element with tag <button> found using index 4

Please notice that time between test start and frontend compilation start is exactly 20s - timeout hardcoded in TestBenchCommandExecutor.waitForVaadin. Issue occurs after switching to Vite.

Setting -Dsystem.com.vaadin.testbench.Parameters.maxAttempts=2 seems to solve the problem.

Somehow related to #1293

There is already a ticket for that 20s timeout: #1244

@MarcinVaadin MarcinVaadin merged commit 11a1655 into master Oct 17, 2022
@MarcinVaadin MarcinVaadin deleted the feature/vaadin-testbench-shared branch October 17, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider separate artifacts for JUnit 4 and JUnit 5
2 participants