You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This dead code was blocking to update to the newest 4.9.0 selenium (and to any new selenium versions after this).
Tests can be a low-hanging fruit, but maybe there are some other utils or other classes which are easier to remove dead code.
Short analysis executed shown 562 opportunities:
Probably not all of them can be removed as some of them are part of abstract classes which used elsewhere, but these methods for example could be removed:
The repository could contain fewer unused code lines, which makes:
dependency addition, removal, bumping,
refactoring, changes also easier,
and just to overview understand the logic, code base better as code is simplified a bit.
potentially builds/compilation time can be faster if we remove a lot of dead codes, although by not much probably :D
Minimal reproducible example
In IntelliJ:
Analyze | Run Inspection by Name... | Unused declaration.
(Potentially worth to add Test regexp or Util regexp, as there will be more false positives otherwise)
Versions
Vaadin / Flow version: latest
The text was updated successfully, but these errors were encountered:
czp13
changed the title
Remove deadcodes .
Remove dead codes.
Apr 22, 2023
Description of the bug
I believe there are some opportunities to remove unused codes.
Similar to this PR (removed dead codes which I have observed accidentally)
This dead code was blocking to update to the newest 4.9.0 selenium (and to any new selenium versions after this).
Tests can be a low-hanging fruit, but maybe there are some other utils or other classes which are easier to remove dead code.
Short analysis executed shown 562 opportunities:
Probably not all of them can be removed as some of them are part of abstract classes which used elsewhere, but these methods for example could be removed:
And so on...
Expected behavior
The repository could contain fewer unused code lines, which makes:
Minimal reproducible example
In IntelliJ:
Analyze | Run Inspection by Name... | Unused declaration.
(Potentially worth to add Test regexp or Util regexp, as there will be more false positives otherwise)
Versions
The text was updated successfully, but these errors were encountered: